Re: [PATCH v5 03/31] exec: Use uintptr_t for guest_base

[Richard Henderson]

On 2/3/21 9:08 AM, Philippe Mathieu-Daudé wrote:
> On 2/3/21 7:59 PM, Richard Henderson wrote:
>> This is more descriptive than 'unsigned long'.
>> No functional change, since these match on all linux+bsd hosts.
>>
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>  include/exec/cpu-all.h | 2 +-
>>  bsd-user/main.c        | 4 ++--
>>  linux-user/elfload.c   | 4 ++--
>>  linux-user/main.c      | 4 ++--
>>  4 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
>> index c23c77589b..c52180e8e6 100644
>> --- a/include/exec/cpu-all.h
>> +++ b/include/exec/cpu-all.h
>> @@ -158,7 +158,7 @@ static inline void tswap64s(uint64_t *s)
>>  /* On some host systems the guest address space is reserved on the host.
>>   * This allows the guest address space to be offset to a convenient 
>> location.
>>   */
>> -extern unsigned long guest_base;
>> +extern uintptr_t guest_base;
>>  extern bool have_guest_base;
>>  extern unsigned long reserved_va;
>>  
>> diff --git a/bsd-user/main.c b/bsd-user/main.c
>> index 65163e1396..c09d74d788 100644
>> --- a/bsd-user/main.c
>> +++ b/bsd-user/main.c
>> @@ -41,7 +41,7 @@
>>  
>>  int singlestep;
>>  unsigned long mmap_min_addr;
>> -unsigned long guest_base;
>> +uintptr_t guest_base;
>>  bool have_guest_base;
>>  unsigned long reserved_va;
>>  
>> @@ -965,7 +965,7 @@ int main(int argc, char **argv)
>>      g_free(target_environ);
>>  
>>      if (qemu_loglevel_mask(CPU_LOG_PAGE)) {
>> -        qemu_log("guest_base  0x%lx\n", guest_base);
>> +        qemu_log("guest_base  %p\n", (void *)guest_base);
> 
> Why not use PRIxPTR?

Didn't think of it.  Worth a respin?

> 
> Otherwise:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>