[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 31/93] tcg/tci: Remove tci_read_r8
From: |
Richard Henderson |
Subject: |
[PATCH v2 31/93] tcg/tci: Remove tci_read_r8 |
Date: |
Wed, 3 Feb 2021 15:44:07 -1000 |
Use explicit casts for ext8u opcodes, and allow truncation
to happen with the store for st8 opcodes.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/tci.c | 23 +++++------------------
1 file changed, 5 insertions(+), 18 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index fb3c97aaf1..c44a4aec7b 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -78,11 +78,6 @@ static int32_t tci_read_reg32s(const tcg_target_ulong *regs,
TCGReg index)
}
#endif
-static uint8_t tci_read_reg8(const tcg_target_ulong *regs, TCGReg index)
-{
- return (uint8_t)tci_read_reg(regs, index);
-}
-
static uint16_t tci_read_reg16(const tcg_target_ulong *regs, TCGReg index)
{
return (uint16_t)tci_read_reg(regs, index);
@@ -169,14 +164,6 @@ tci_read_r(const tcg_target_ulong *regs, const uint8_t
**tb_ptr)
return value;
}
-/* Read indexed register (8 bit) from bytecode. */
-static uint8_t tci_read_r8(const tcg_target_ulong *regs, const uint8_t
**tb_ptr)
-{
- uint8_t value = tci_read_reg8(regs, **tb_ptr);
- *tb_ptr += 1;
- return value;
-}
-
#if TCG_TARGET_HAS_ext8s_i32 || TCG_TARGET_HAS_ext8s_i64
/* Read indexed register (8 bit signed) from bytecode. */
static int8_t tci_read_r8s(const tcg_target_ulong *regs, const uint8_t
**tb_ptr)
@@ -550,7 +537,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
*env,
tci_write_reg(regs, t0, *(uint32_t *)(t1 + t2));
break;
CASE_32_64(st8)
- t0 = tci_read_r8(regs, &tb_ptr);
+ t0 = tci_read_r(regs, &tb_ptr);
t1 = tci_read_r(regs, &tb_ptr);
t2 = tci_read_s32(&tb_ptr);
*(uint8_t *)(t1 + t2) = t0;
@@ -739,8 +726,8 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
*env,
#if TCG_TARGET_HAS_ext8u_i32
case INDEX_op_ext8u_i32:
t0 = *tb_ptr++;
- t1 = tci_read_r8(regs, &tb_ptr);
- tci_write_reg(regs, t0, t1);
+ t1 = tci_read_r(regs, &tb_ptr);
+ tci_write_reg(regs, t0, (uint8_t)t1);
break;
#endif
#if TCG_TARGET_HAS_ext16u_i32
@@ -933,8 +920,8 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
*env,
#if TCG_TARGET_HAS_ext8u_i64
case INDEX_op_ext8u_i64:
t0 = *tb_ptr++;
- t1 = tci_read_r8(regs, &tb_ptr);
- tci_write_reg(regs, t0, t1);
+ t1 = tci_read_r(regs, &tb_ptr);
+ tci_write_reg(regs, t0, (uint8_t)t1);
break;
#endif
#if TCG_TARGET_HAS_ext8s_i64
--
2.25.1
- Re: [PATCH v2 29/93] tcg/tci: Remove TCG_CONST, (continued)
[PATCH v2 45/93] tcg/tci: Split out tci_args_rrr, Richard Henderson, 2021/02/03
[PATCH v2 51/93] tcg/tci: Reuse tci_args_l for calls., Richard Henderson, 2021/02/03
[PATCH v2 53/93] tcg/tci: Reuse tci_args_l for goto_tb, Richard Henderson, 2021/02/03
[PATCH v2 55/93] tcg/tci: Split out tci_args_rrrr, Richard Henderson, 2021/02/03
[PATCH v2 32/93] tcg/tci: Remove tci_read_r8s, Richard Henderson, 2021/02/03
[PATCH v2 34/93] tcg/tci: Remove tci_read_r16s, Richard Henderson, 2021/02/03
[PATCH v2 33/93] tcg/tci: Remove tci_read_r16, Richard Henderson, 2021/02/03
[PATCH v2 36/93] tcg/tci: Reduce use of tci_read_r64, Richard Henderson, 2021/02/03
[PATCH v2 31/93] tcg/tci: Remove tci_read_r8,
Richard Henderson <=
[PATCH v2 37/93] tcg/tci: Merge basic arithmetic operations, Richard Henderson, 2021/02/03
[PATCH v2 40/93] tcg/tci: Merge bswap operations, Richard Henderson, 2021/02/03
[PATCH v2 42/93] tcg/tci: Rename tci_read_r to tci_read_rval, Richard Henderson, 2021/02/03
[PATCH v2 47/93] tcg/tci: Split out tci_args_l, Richard Henderson, 2021/02/03
[PATCH v2 49/93] tcg/tci: Split out tci_args_rrcl and tci_args_rrrrcl, Richard Henderson, 2021/02/03
[PATCH v2 46/93] tcg/tci: Split out tci_args_rrrc, Richard Henderson, 2021/02/03
[PATCH v2 50/93] tcg/tci: Split out tci_args_ri and tci_args_rI, Richard Henderson, 2021/02/03
[PATCH v2 52/93] tcg/tci: Reuse tci_args_l for exit_tb, Richard Henderson, 2021/02/03
[PATCH v2 54/93] tcg/tci: Split out tci_args_rrrrrr, Richard Henderson, 2021/02/03
[PATCH v2 56/93] tcg/tci: Clean up deposit operations, Richard Henderson, 2021/02/03