[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/93] TCI fixes and cleanups
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 00/93] TCI fixes and cleanups |
Date: |
Thu, 4 Feb 2021 09:58:30 +0000 |
On Thu, 4 Feb 2021 at 01:49, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Almost 7 years ago I detailed 5 major problems in tci[1], of
> which three still remain:
>
> * Unaligned accesses to the bytecode stream, which means
> that we immediately SIGBUS on any host requiring alignment.
> * Non-portable calls to helper functions.
> * Full of useless ifdefs and TODOs.
>
> To my mind, this means the code is unmaintained, despite what it
> says in MAINTAINERS. Thus tci *should* be simply removed.
> However, every time removal is suggested, someone comes out of the
> woodwork and says we should keep it, because it's useful for $FOO.
Not listed, but also a problem:
* it's a configure-time choice, not a runtime choice
(Personally I'm on the "we should just remove it" side.)
thanks
-- PMM
- [PATCH v2 85/93] tcg/tci: Remove tci_write_reg, (continued)
- [PATCH v2 85/93] tcg/tci: Remove tci_write_reg, Richard Henderson, 2021/02/03
- [PATCH v2 86/93] tcg/tci: Change encoding to uint32_t units, Richard Henderson, 2021/02/03
- [PATCH v2 87/93] tcg/tci: Implement goto_ptr, Richard Henderson, 2021/02/03
- [PATCH v2 88/93] tcg/tci: Implement movcond, Richard Henderson, 2021/02/03
- [PATCH v2 89/93] tcg/tci: Implement andc, orc, eqv, nand, nor, Richard Henderson, 2021/02/03
- [PATCH v2 90/93] tcg/tci: Implement extract, sextract, Richard Henderson, 2021/02/03
- [PATCH v2 91/93] tcg/tci: Implement clz, ctz, ctpop, Richard Henderson, 2021/02/03
- [PATCH v2 92/93] tcg/tci: Implement mulu2, muls2, Richard Henderson, 2021/02/03
- [PATCH v2 93/93] tcg/tci: Implement add2, sub2, Richard Henderson, 2021/02/03
- Re: [PATCH v2 00/93] TCI fixes and cleanups, no-reply, 2021/02/03
- Re: [PATCH v2 00/93] TCI fixes and cleanups,
Peter Maydell <=