Re: [PATCH 02/12] qga: Rename config key 'blacklist' as 'denylist'

[Michal Suchánek]

On Thu, Feb 04, 2021 at 10:45:45AM +0100, Michal Suchánek wrote:
> Hello,
> 
> On Tue, Feb 02, 2021 at 09:58:14PM +0100, Philippe Mathieu-Daudé wrote:
> > Follow the inclusive terminology from the "Conscious Language in your
> > Open Source Projects" guidelines [*] and replace the word "blacklist"
> > appropriately.
> > 
> > [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md
> > 
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> >  docs/interop/qemu-ga.rst   |  2 +-
> >  qga/main.c                 | 15 +++++++++++----
> >  tests/test-qga.c           |  8 ++++----
> >  tests/data/test-qga-config |  2 +-
> >  4 files changed, 17 insertions(+), 10 deletions(-)
> > 
> > diff --git a/docs/interop/qemu-ga.rst b/docs/interop/qemu-ga.rst
> > index 3063357bb5d..9a590bf95cb 100644
> > --- a/docs/interop/qemu-ga.rst
> > +++ b/docs/interop/qemu-ga.rst
> > @@ -125,7 +125,7 @@ pidfile        string
> >  fsfreeze-hook  string
> >  statedir       string
> >  verbose        boolean
> > -blacklist      string list
> > +denylist       string list
> >  =============  ===========
> 
> this changes the config option but not the commandline option creating
> disconnect between commanndline and config:
> 
> docs/interop/qemu-ga.rst:.. option:: -b, --blacklist=LIST
> docs/interop/qemu-ga.rst:blacklist      string list

Now I see it's addressed in patch 3 but with the patches arriving out of
order I have missed that. Maybe merging these two might make more sense.

Thanks

Michal