qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] exec/cpu-defs: Remove TCG backends dependency


From: Paolo Bonzini
Subject: Re: [PATCH] exec/cpu-defs: Remove TCG backends dependency
Date: Thu, 4 Feb 2021 19:19:42 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 04/02/21 19:03, Philippe Mathieu-Daudé wrote:
"exec/cpu-defs.h" contains common CPU definitions for
accelerators, which is not related to the TCG backends.
See tcg/README description:

Most of the definitions are actually for TCG, not for all accelerators (the TLB mostly).

However, they're indeed unrelated to the backends, so

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

I'll let the TCG people pick it up.

Paolo

   4) Backend

   tcg-target.h contains the target specific definitions. tcg-target.c.inc
   contains the target specific code; it is #included by tcg/tcg.c, rather
   than being a standalone C file.

So far only "tcg/tcg.h" requires these headers.

Remove the "target-tcg.h" header dependency on accelerators.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
  include/exec/cpu-defs.h | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h
index d1f5e3fc3d8..ba3cd32a1ec 100644
--- a/include/exec/cpu-defs.h
+++ b/include/exec/cpu-defs.h
@@ -25,9 +25,6 @@
#include "qemu/host-utils.h"
  #include "qemu/thread.h"
-#ifdef CONFIG_TCG
-#include "tcg-target.h"
-#endif
  #ifndef CONFIG_USER_ONLY
  #include "exec/hwaddr.h"
  #endif





reply via email to

[Prev in Thread] Current Thread [Next in Thread]