[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] migration: dirty-bitmap: Convert alias map inner members
From: |
Eric Blake |
Subject: |
Re: [PATCH 1/2] migration: dirty-bitmap: Convert alias map inner members to a struct |
Date: |
Thu, 4 Feb 2021 13:12:12 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/3/21 6:59 AM, Peter Krempa wrote:
> Currently the alias mapping hash stores just strings of the target
> objects internally. In further patches we'll be adding another member
> which will need to be stored in the map so convert the members to a
> struct.
>
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
> migration/block-dirty-bitmap.c | 37 ++++++++++++++++++++++++++++------
> 1 file changed, 31 insertions(+), 6 deletions(-)
>
> diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
> index c61d382be8..b0403dd00c 100644
> --- a/migration/block-dirty-bitmap.c
> +++ b/migration/block-dirty-bitmap.c
> @@ -169,6 +169,18 @@ typedef struct DBMState {
>
> static DBMState dbm_state;
>
> +typedef struct AliasMapInnerBitmap {
> + char *string;
> +} AliasMapInnerBitmap;
> +
> +static void free_alias_map_inner_bitmap(void *amin_ptr)
> +{
> + AliasMapInnerBitmap *amin = amin_ptr;
> +
> + g_free(amin->string);
Do we want to allow free_alias_map_inner_bitmap(NULL)?
Looks like this patch works without it, but it's less future proof, so I
can add that if you agree.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org