[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 01/14] block: return status from bdrv_append and friends
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH v7 01/14] block: return status from bdrv_append and friends |
|
Date: |
Fri, 05 Feb 2021 12:16:29 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 02 Feb 2021 01:49:43 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> The recommended use of qemu error api assumes returning status together
> with setting errp and avoid void functions with errp parameter. Let's
> improve bdrv_append and some friends to reduce error-propagation
> overhead in further patches.
>
> Choose int return status, because bdrv_replace_node_common() has call
> to bdrv_check_update_perm(), which reports int status, which seems
> correct to propagate.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
I had already reviewed this one, hadn't I?
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
- [PATCH v7 00/14] block: deal with errp: part I, Vladimir Sementsov-Ogievskiy, 2021/02/02
- [PATCH v7 01/14] block: return status from bdrv_append and friends, Vladimir Sementsov-Ogievskiy, 2021/02/02
- Re: [PATCH v7 01/14] block: return status from bdrv_append and friends,
Alberto Garcia <=
- [PATCH v7 04/14] blockdev: fix drive_backup_prepare() missed error, Vladimir Sementsov-Ogievskiy, 2021/02/02
- [PATCH v7 05/14] block: drop extra error propagation for bdrv_set_backing_hd, Vladimir Sementsov-Ogievskiy, 2021/02/02
- [PATCH v7 02/14] block: use return status of bdrv_append(), Vladimir Sementsov-Ogievskiy, 2021/02/02
- [PATCH v7 03/14] block: check return value of bdrv_open_child and drop error propagation, Vladimir Sementsov-Ogievskiy, 2021/02/02