Re: [PATCH 1/2] build: add configure flag to indicate when the host is Darwin

[Phillip Tennen]

Hrm, good catch. I'm not sure how I missed that.

I'm removing this patch for my next round.

Thanks!

Phillip

On Fri, Feb 5, 2021 at 6:56 AM Thomas Huth <thuth@redhat.com> wrote:

On 04/02/2021 17.25, phillip.ennen@gmail.com wrote:
> From: Phillip Tennen <phillip@axleos.com>
>
> Although we already have CONFIG_BSD, I added this flag to be sure that we could rely on various macOS-specific subsystems, such as vmnet.framework.
>
> Signed-off-by: Phillip Tennen <phillip@axleos.com>
> ---
>   configure | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/configure b/configure
> index 87de49e2c2..4afd22bdf5 100755
> --- a/configure
> +++ b/configure
> @@ -5825,6 +5825,10 @@ if [ "$bsd" = "yes" ] ; then
>     echo "CONFIG_BSD=y" >> $config_host_mak
>   fi
>   
> +if [ "$darwin" = "yes" ] ; then
> +  echo "CONFIG_DARWIN=y" >> $config_host_mak
> +fi

  Hi!

We already have these lines in "configure":

if test "$darwin" = "yes" ; then
   echo "CONFIG_DARWIN=y" >> $config_host_mak
fi

... so your patch here looks pretty redundant?

  Thomas