[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/33] migration: push Error **errp into loadvm_postcopy_ram_
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 14/33] migration: push Error **errp into loadvm_postcopy_ram_handle_discard() |
Date: |
Fri, 5 Feb 2021 17:24:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 2/4/21 6:18 PM, Daniel P. Berrangé wrote:
> This is an incremental step in converting vmstate loading code to report
> via Error objects instead of printing directly to the console/monitor.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> migration/savevm.c | 31 +++++++++++++++----------------
> 1 file changed, 15 insertions(+), 16 deletions(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index fa7883ae5e..2216c61c6f 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -1735,7 +1735,8 @@ static int
> loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
> * There can be 0..many of these messages, each encoding multiple pages.
> */
> static int loadvm_postcopy_ram_handle_discard(MigrationIncomingState *mis,
> - uint16_t len)
> + uint16_t len,
> + Error **errp)
> {
> int tmp;
> char ramid[256];
> @@ -1748,7 +1749,8 @@ static int
> loadvm_postcopy_ram_handle_discard(MigrationIncomingState *mis,
> /* 1st discard */
> tmp = postcopy_ram_prepare_discard(mis);
> if (tmp) {
> - return tmp;
> + error_setg(errp, "Failed to prepare for RAM discard: %d", tmp);
New error, OK.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> + return -1;
> }
- Re: [PATCH 08/33] migration: push Error **errp into loadvm_process_command(), (continued)
- [PATCH 10/33] migration: push Error **errp into loadvm_postcopy_handle_advise(), Daniel P . Berrangé, 2021/02/04
- [PATCH 11/33] migration: push Error **errp into ram_postcopy_incoming_init(), Daniel P . Berrangé, 2021/02/04
- [PATCH 13/33] migration: push Error **errp into loadvm_postcopy_handle_run(), Daniel P . Berrangé, 2021/02/04
- [PATCH 12/33] migration: push Error **errp into loadvm_postcopy_handle_listen(), Daniel P . Berrangé, 2021/02/04
- [PATCH 15/33] migration: make loadvm_postcopy_handle_resume() void, Daniel P . Berrangé, 2021/02/04
- [PATCH 14/33] migration: push Error **errp into loadvm_postcopy_ram_handle_discard(), Daniel P . Berrangé, 2021/02/04
- Re: [PATCH 14/33] migration: push Error **errp into loadvm_postcopy_ram_handle_discard(),
Philippe Mathieu-Daudé <=
- [PATCH 16/33] migration: push Error **errp into loadvm_handle_recv_bitmap(), Daniel P . Berrangé, 2021/02/04
- [PATCH 17/33] migration: push Error **errp into loadvm_process_enable_colo(), Daniel P . Berrangé, 2021/02/04
- [PATCH 18/33] migration: push Error **errp into colo_init_ram_cache(), Daniel P . Berrangé, 2021/02/04
- [PATCH 23/33] migration: simplify some error reporting in save_snapshot(), Daniel P . Berrangé, 2021/02/04
- [PATCH 19/33] migration: push Error **errp into check_section_footer(), Daniel P . Berrangé, 2021/02/04
- [PATCH 21/33] migration: remove error reporting from qemu_fopen_bdrv() callers, Daniel P . Berrangé, 2021/02/04
- [PATCH 20/33] migration: push Error **errp into global_state_store(), Daniel P . Berrangé, 2021/02/04
- [PATCH 25/33] migration: push Error **errp into qemu_savevm_state_complete_precopy(), Daniel P . Berrangé, 2021/02/04
- [PATCH 22/33] migration: push Error **errp into qemu_savevm_state_iterate(), Daniel P . Berrangé, 2021/02/04