[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 23/27] migration: introduce a delete_snapshot wrapper
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 23/27] migration: introduce a delete_snapshot wrapper |
Date: |
Mon, 8 Feb 2021 11:29:14 +0000 |
From: Daniel P. Berrangé <berrange@redhat.com>
Make snapshot deletion consistent with the snapshot save
and load commands by using a wrapper around the blockdev
layer. The main difference is that we get upfront validation
of the passed in device list (if any).
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20210204124834.774401-10-berrange@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
include/migration/snapshot.h | 13 +++++++++++++
migration/savevm.c | 14 ++++++++++++++
monitor/hmp-cmds.c | 2 +-
3 files changed, 28 insertions(+), 1 deletion(-)
diff --git a/include/migration/snapshot.h b/include/migration/snapshot.h
index 3bdbef435b..e72083b117 100644
--- a/include/migration/snapshot.h
+++ b/include/migration/snapshot.h
@@ -48,4 +48,17 @@ bool load_snapshot(const char *name,
bool has_devices, strList *devices,
Error **errp);
+/**
+ * delete_snapshot: Delete a snapshot.
+ * @name: path to snapshot
+ * @has_devices: whether to use explicit device list
+ * @devices: explicit device list to snapshot
+ * @errp: pointer to error object
+ * On success, return %true.
+ * On failure, store an error through @errp and return %false.
+ */
+bool delete_snapshot(const char *name,
+ bool has_devices, strList *devices,
+ Error **errp);
+
#endif
diff --git a/migration/savevm.c b/migration/savevm.c
index 0b27a8c55a..0c5d61ae20 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -3071,6 +3071,20 @@ err_drain:
return false;
}
+bool delete_snapshot(const char *name, bool has_devices,
+ strList *devices, Error **errp)
+{
+ if (!bdrv_all_can_snapshot(has_devices, devices, errp)) {
+ return false;
+ }
+
+ if (bdrv_all_delete_snapshot(name, has_devices, devices, errp) < 0) {
+ return false;
+ }
+
+ return true;
+}
+
void vmstate_register_ram(MemoryRegion *mr, DeviceState *dev)
{
qemu_ram_set_idstr(mr->ram_block,
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 15d4e039ac..3c88a4faef 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1159,7 +1159,7 @@ void hmp_delvm(Monitor *mon, const QDict *qdict)
Error *err = NULL;
const char *name = qdict_get_str(qdict, "name");
- bdrv_all_delete_snapshot(name, false, NULL, &err);
+ delete_snapshot(name, false, NULL, &err);
hmp_handle_error(mon, err);
}
--
2.29.2
- [PULL 14/27] migration: Display the migration blockers, (continued)
- [PULL 14/27] migration: Display the migration blockers, Dr. David Alan Gilbert (git), 2021/02/08
- [PULL 20/27] block: rename and alter bdrv_all_find_snapshot semantics, Dr. David Alan Gilbert (git), 2021/02/08
- [PULL 16/27] migration: Make save_snapshot() return bool, not 0/-1, Dr. David Alan Gilbert (git), 2021/02/08
- [PULL 18/27] block: add ability to specify list of blockdevs during snapshot, Dr. David Alan Gilbert (git), 2021/02/08
- [PULL 21/27] migration: control whether snapshots are ovewritten, Dr. David Alan Gilbert (git), 2021/02/08
- [PULL 25/27] iotests: fix loading of common.config from tests/ subdir, Dr. David Alan Gilbert (git), 2021/02/08
- [PULL 24/27] iotests: add support for capturing and matching QMP events, Dr. David Alan Gilbert (git), 2021/02/08
- [PULL 15/27] block: push error reporting into bdrv_all_*_snapshot functions, Dr. David Alan Gilbert (git), 2021/02/08
- [PULL 19/27] block: allow specifying name of block device for vmstate storage, Dr. David Alan Gilbert (git), 2021/02/08
- [PULL 22/27] migration: wire up support for snapshot device selection, Dr. David Alan Gilbert (git), 2021/02/08
- [PULL 23/27] migration: introduce a delete_snapshot wrapper,
Dr. David Alan Gilbert (git) <=
- [PULL 26/27] migration: introduce snapshot-{save, load, delete} QMP commands, Dr. David Alan Gilbert (git), 2021/02/08
- [PULL 27/27] migration: only check page size match if RAM postcopy is enabled, Dr. David Alan Gilbert (git), 2021/02/08
- Re: [PULL 00/27] migration queue, Peter Maydell, 2021/02/08