qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v16 21/23] accel: introduce new accessor functions


From: Claudio Fontana
Subject: Re: [PATCH v16 21/23] accel: introduce new accessor functions
Date: Mon, 8 Feb 2021 13:50:54 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0

On 2/5/21 9:14 PM, Richard Henderson wrote:
> On 2/4/21 6:39 AM, Claudio Fontana wrote:
>> @@ -6725,10 +6722,8 @@ static void x86_cpu_initfn(Object *obj)
>>          x86_cpu_load_model(cpu, xcc->model);
>>      }
>>  
>> -    /* if required, do the accelerator-specific cpu initialization */
>> -    if (cc->accel_cpu) {
>> -        cc->accel_cpu->cpu_instance_init(CPU(obj));
>> -    }
>> +    /* if required, do accelerator-specific cpu initializations */
>> +    accel_cpu_instance_init(CPU(obj));
>>  }
> 
> Why is this only done for x86?
> 
> 
> r~
> 

It makes sense to include the other architectures.

As the next step I would like to apply this to ARM, but to me it makes sense to 
first complete Philippe's series,
which reshuffles things so that TCG-only / KVM-only builds are both possible 
and error-free:

https://www.mail-archive.com/qemu-devel@nongnu.org/msg777627.html

Thanks,

Claudio










reply via email to

[Prev in Thread] Current Thread [Next in Thread]