[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 14/31] linux-user: Use guest_range_valid in access_ok
From: |
Richard Henderson |
Subject: |
[PATCH v6 14/31] linux-user: Use guest_range_valid in access_ok |
Date: |
Tue, 9 Feb 2021 16:02:06 -0800 |
We're currently open-coding the range check in access_ok;
use guest_range_valid when size != 0.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/qemu.h | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 9fbc5edc4b..ba122a7903 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -493,12 +493,9 @@ extern unsigned long guest_stack_size;
static inline bool access_ok(int type, abi_ulong addr, abi_ulong size)
{
- if (!guest_addr_valid(addr)) {
- return false;
- }
- if (size != 0 &&
- (addr + size - 1 < addr ||
- !guest_addr_valid(addr + size - 1))) {
+ if (size == 0
+ ? !guest_addr_valid(addr)
+ : !guest_range_valid(addr, size)) {
return false;
}
return page_check_range((target_ulong)addr, size, type) == 0;
--
2.25.1
- [PATCH v6 00/31] target-arm: Implement ARMv8.5-MemTag, user mode, Richard Henderson, 2021/02/09
- [PATCH v6 01/31] tcg: Introduce target-specific page data for user-only, Richard Henderson, 2021/02/09
- [PATCH v6 03/31] exec: Use uintptr_t for guest_base, Richard Henderson, 2021/02/09
- [PATCH v6 02/31] linux-user: Introduce PAGE_ANON, Richard Henderson, 2021/02/09
- [PATCH v6 05/31] exec: Improve types for guest_addr_valid, Richard Henderson, 2021/02/09
- [PATCH v6 04/31] exec: Use uintptr_t in cpu_ldst.h, Richard Henderson, 2021/02/09
- [PATCH v6 07/31] linux-user: Tidy VERIFY_READ/VERIFY_WRITE, Richard Henderson, 2021/02/09
- [PATCH v6 06/31] linux-user: Check for overflow in access_ok, Richard Henderson, 2021/02/09
- [PATCH v6 08/31] bsd-user: Tidy VERIFY_READ/VERIFY_WRITE, Richard Henderson, 2021/02/09
- [PATCH v6 13/31] linux-user: Explicitly untag memory management syscalls, Richard Henderson, 2021/02/09
- [PATCH v6 14/31] linux-user: Use guest_range_valid in access_ok,
Richard Henderson <=
- [PATCH v6 09/31] linux-user: Do not use guest_addr_valid for h2g_valid, Richard Henderson, 2021/02/09
- [PATCH v6 12/31] exec: Use cpu_untagged_addr in g2h; split out g2h_untagged, Richard Henderson, 2021/02/09
- [PATCH v6 10/31] linux-user: Fix guest_addr_valid vs reserved_va, Richard Henderson, 2021/02/09
- [PATCH v6 11/31] exec: Introduce cpu_untagged_addr, Richard Henderson, 2021/02/09
- [PATCH v6 16/31] linux-user: Use cpu_untagged_addr in access_ok; split out *_untagged, Richard Henderson, 2021/02/09
- [PATCH v6 18/31] linux-user: Fix types in uaccess.c, Richard Henderson, 2021/02/09
- [PATCH v6 15/31] exec: Rename guest_{addr,range}_valid to *_untagged, Richard Henderson, 2021/02/09
- [PATCH v6 17/31] linux-user: Move lock_user et al out of line, Richard Henderson, 2021/02/09
- [PATCH v6 20/31] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE, Richard Henderson, 2021/02/09
- [PATCH v6 30/31] target/arm: Enable MTE for user-only, Richard Henderson, 2021/02/09