qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] hw/block/nvme: add write uncorrectable command


From: Minwoo Im
Subject: Re: [PATCH 2/2] hw/block/nvme: add write uncorrectable command
Date: Thu, 11 Feb 2021 00:28:13 +0900
User-agent: Mutt/1.11.4 (2019-03-13)

> > It might be nitpick, 'nlb' would easily represent the value which is
> > defined itself in the spec which is zero-based.  Can we have this like:
> > 
> >     uint32_t nlb = le16_to_cpu(rw->nlb);
> > 
> >     bitmap_clear(ns->uncorrectable, slba, nlb + 1);
> > 
> 
> 
> I do not disagree, but the `uint32_t nlb = le16_to_cpu(rw->nlb) + 1;`
> pattern is already used in several places.

Oh yes, Now I just saw some places.  Then, please take my review tag for
this patch.

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]