[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC v17 12/14] i386: separate fpu_helper into user and softmmu parts
From: |
Claudio Fontana |
Subject: |
[RFC v17 12/14] i386: separate fpu_helper into user and softmmu parts |
Date: |
Wed, 10 Feb 2021 16:28:57 +0100 |
Signed-off-by: Claudio Fontana <cfontana@suse.de>
---
target/i386/cpu.h | 3 +
target/i386/tcg/fpu_helper.c | 58 +----------------
target/i386/tcg/softmmu/fpu_helper_softmmu.c | 67 ++++++++++++++++++++
target/i386/tcg/user/fpu_helper_user.c | 49 ++++++++++++++
target/i386/tcg/softmmu/meson.build | 1 +
target/i386/tcg/user/meson.build | 1 +
6 files changed, 123 insertions(+), 56 deletions(-)
create mode 100644 target/i386/tcg/softmmu/fpu_helper_softmmu.c
create mode 100644 target/i386/tcg/user/fpu_helper_user.c
diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index a4f9bbef55..afcf34e40b 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -1811,7 +1811,10 @@ int cpu_x86_support_mca_broadcast(CPUX86State *env);
int cpu_get_pic_interrupt(CPUX86State *s);
/* MSDOS compatibility mode FPU exception support */
void x86_register_ferr_irq(qemu_irq irq);
+bool fpu_check_raise_ferr_irq(CPUX86State *s);
void cpu_set_ignne(void);
+void cpu_clear_ignne(void);
+
/* mpx_helper.c */
void cpu_sync_bndcs_hflags(CPUX86State *env);
diff --git a/target/i386/tcg/fpu_helper.c b/target/i386/tcg/fpu_helper.c
index 60ed93520a..c4196d4ff0 100644
--- a/target/i386/tcg/fpu_helper.c
+++ b/target/i386/tcg/fpu_helper.c
@@ -75,36 +75,6 @@
#define floatx80_ln2_d make_floatx80(0x3ffe, 0xb17217f7d1cf79abLL)
#define floatx80_pi_d make_floatx80(0x4000, 0xc90fdaa22168c234LL)
-#if !defined(CONFIG_USER_ONLY)
-static qemu_irq ferr_irq;
-
-void x86_register_ferr_irq(qemu_irq irq)
-{
- ferr_irq = irq;
-}
-
-static void cpu_clear_ignne(void)
-{
- CPUX86State *env = &X86_CPU(first_cpu)->env;
- env->hflags2 &= ~HF2_IGNNE_MASK;
-}
-
-void cpu_set_ignne(void)
-{
- CPUX86State *env = &X86_CPU(first_cpu)->env;
- env->hflags2 |= HF2_IGNNE_MASK;
- /*
- * We get here in response to a write to port F0h. The chipset should
- * deassert FP_IRQ and FERR# instead should stay signaled until FPSW_SE is
- * cleared, because FERR# and FP_IRQ are two separate pins on real
- * hardware. However, we don't model FERR# as a qemu_irq, so we just
- * do directly what the chipset would do, i.e. deassert FP_IRQ.
- */
- qemu_irq_lower(ferr_irq);
-}
-#endif
-
-
static inline void fpush(CPUX86State *env)
{
env->fpstt = (env->fpstt - 1) & 7;
@@ -203,8 +173,8 @@ static void fpu_raise_exception(CPUX86State *env, uintptr_t
retaddr)
raise_exception_ra(env, EXCP10_COPR, retaddr);
}
#if !defined(CONFIG_USER_ONLY)
- else if (ferr_irq && !(env->hflags2 & HF2_IGNNE_MASK)) {
- qemu_irq_raise(ferr_irq);
+ else {
+ (void)fpu_check_raise_ferr_irq(env);
}
#endif
}
@@ -2501,18 +2471,6 @@ void helper_frstor(CPUX86State *env, target_ulong ptr,
int data32)
}
}
-#if defined(CONFIG_USER_ONLY)
-void cpu_x86_fsave(CPUX86State *env, target_ulong ptr, int data32)
-{
- helper_fsave(env, ptr, data32);
-}
-
-void cpu_x86_frstor(CPUX86State *env, target_ulong ptr, int data32)
-{
- helper_frstor(env, ptr, data32);
-}
-#endif
-
#define XO(X) offsetof(X86XSaveArea, X)
static void do_xsave_fpu(CPUX86State *env, target_ulong ptr, uintptr_t ra)
@@ -2780,18 +2738,6 @@ void helper_fxrstor(CPUX86State *env, target_ulong ptr)
}
}
-#if defined(CONFIG_USER_ONLY)
-void cpu_x86_fxsave(CPUX86State *env, target_ulong ptr)
-{
- helper_fxsave(env, ptr);
-}
-
-void cpu_x86_fxrstor(CPUX86State *env, target_ulong ptr)
-{
- helper_fxrstor(env, ptr);
-}
-#endif
-
void helper_xrstor(CPUX86State *env, target_ulong ptr, uint64_t rfbm)
{
uintptr_t ra = GETPC();
diff --git a/target/i386/tcg/softmmu/fpu_helper_softmmu.c
b/target/i386/tcg/softmmu/fpu_helper_softmmu.c
new file mode 100644
index 0000000000..c3c78f4e28
--- /dev/null
+++ b/target/i386/tcg/softmmu/fpu_helper_softmmu.c
@@ -0,0 +1,67 @@
+/*
+ * x86 FPU, MMX/3DNow!/SSE/SSE2/SSE3/SSSE3/SSE4/PNI helpers (softmmu code)
+ *
+ * Copyright (c) 2003 Fabrice Bellard
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "qemu/osdep.h"
+#include <math.h>
+#include "cpu.h"
+#include "exec/helper-proto.h"
+#include "qemu/host-utils.h"
+#include "exec/exec-all.h"
+#include "exec/cpu_ldst.h"
+#include "fpu/softfloat.h"
+#include "fpu/softfloat-macros.h"
+#include "tcg/helper-tcg.h"
+
+#include "hw/irq.h"
+
+static qemu_irq ferr_irq;
+
+void x86_register_ferr_irq(qemu_irq irq)
+{
+ ferr_irq = irq;
+}
+
+bool fpu_check_raise_ferr_irq(CPUX86State *env)
+{
+ if (ferr_irq && !(env->hflags2 & HF2_IGNNE_MASK)) {
+ qemu_irq_raise(ferr_irq);
+ return true;
+ }
+ return false;
+}
+
+void cpu_clear_ignne(void)
+{
+ CPUX86State *env = &X86_CPU(first_cpu)->env;
+ env->hflags2 &= ~HF2_IGNNE_MASK;
+}
+
+void cpu_set_ignne(void)
+{
+ CPUX86State *env = &X86_CPU(first_cpu)->env;
+ env->hflags2 |= HF2_IGNNE_MASK;
+ /*
+ * We get here in response to a write to port F0h. The chipset should
+ * deassert FP_IRQ and FERR# instead should stay signaled until FPSW_SE is
+ * cleared, because FERR# and FP_IRQ are two separate pins on real
+ * hardware. However, we don't model FERR# as a qemu_irq, so we just
+ * do directly what the chipset would do, i.e. deassert FP_IRQ.
+ */
+ qemu_irq_lower(ferr_irq);
+}
diff --git a/target/i386/tcg/user/fpu_helper_user.c
b/target/i386/tcg/user/fpu_helper_user.c
new file mode 100644
index 0000000000..7c0782ebca
--- /dev/null
+++ b/target/i386/tcg/user/fpu_helper_user.c
@@ -0,0 +1,49 @@
+/*
+ * x86 FPU, MMX/3DNow!/SSE/SSE2/SSE3/SSSE3/SSE4/PNI helpers (user-mode)
+ *
+ * Copyright (c) 2003 Fabrice Bellard
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "qemu/osdep.h"
+#include <math.h>
+#include "cpu.h"
+#include "exec/helper-proto.h"
+#include "qemu/host-utils.h"
+#include "exec/exec-all.h"
+#include "exec/cpu_ldst.h"
+#include "fpu/softfloat.h"
+#include "fpu/softfloat-macros.h"
+#include "tcg/helper-tcg.h"
+
+void cpu_x86_fsave(CPUX86State *env, target_ulong ptr, int data32)
+{
+ helper_fsave(env, ptr, data32);
+}
+
+void cpu_x86_frstor(CPUX86State *env, target_ulong ptr, int data32)
+{
+ helper_frstor(env, ptr, data32);
+}
+
+void cpu_x86_fxsave(CPUX86State *env, target_ulong ptr)
+{
+ helper_fxsave(env, ptr);
+}
+
+void cpu_x86_fxrstor(CPUX86State *env, target_ulong ptr)
+{
+ helper_fxrstor(env, ptr);
+}
diff --git a/target/i386/tcg/softmmu/meson.build
b/target/i386/tcg/softmmu/meson.build
index 50b830419d..63576e5833 100644
--- a/target/i386/tcg/softmmu/meson.build
+++ b/target/i386/tcg/softmmu/meson.build
@@ -4,4 +4,5 @@ i386_softmmu_ss.add(when: ['CONFIG_TCG', 'CONFIG_SOFTMMU'],
if_true: files(
'excp_helper_softmmu.c',
'bpt_helper_softmmu.c',
'misc_helper_softmmu.c',
+ 'fpu_helper_softmmu.c',
))
diff --git a/target/i386/tcg/user/meson.build b/target/i386/tcg/user/meson.build
index 0fa9a48ee3..e0fb69e601 100644
--- a/target/i386/tcg/user/meson.build
+++ b/target/i386/tcg/user/meson.build
@@ -4,4 +4,5 @@ i386_user_ss.add(when: ['CONFIG_TCG', 'CONFIG_USER_ONLY'],
if_true: files(
'excp_helper_user.c',
'bpt_helper_user.c',
'misc_helper_user.c',
+ 'fpu_helper_user.c',
))
--
2.26.2
- [RFC v17 00/14] i386 cleanup PART 2, Claudio Fontana, 2021/02/10
- [RFC v17 02/14] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn, Claudio Fontana, 2021/02/10
- [RFC v17 04/14] target/i386: fix host_cpu_adjust_phys_bits error handling, Claudio Fontana, 2021/02/10
- [RFC v17 03/14] accel: introduce new accessor functions, Claudio Fontana, 2021/02/10
- [RFC v17 08/14] i386: split smm helper (softmmu), Claudio Fontana, 2021/02/10
- [RFC v17 06/14] meson: add target_user_arch, Claudio Fontana, 2021/02/10
- [RFC v17 01/14] i386: split cpu accelerators from cpu.c, using AccelCPUClass, Claudio Fontana, 2021/02/10
- [RFC v17 05/14] accel-cpu: make cpu_realizefn return a bool, Claudio Fontana, 2021/02/10
- [RFC v17 07/14] i386: split user and softmmu functionality in tcg-cpu, Claudio Fontana, 2021/02/10
- [RFC v17 09/14] i386: split tcg excp_helper into softmmu and user parts, Claudio Fontana, 2021/02/10
- [RFC v17 12/14] i386: separate fpu_helper into user and softmmu parts,
Claudio Fontana <=
- [RFC v17 11/14] i386: split misc helper into user and softmmu parts, Claudio Fontana, 2021/02/10
- [RFC v17 10/14] i386: split tcg btp_helper into softmmu and user parts, Claudio Fontana, 2021/02/10
[RFC v17 13/14] i386: slit svm_helper into softmmu and stub-only user, Claudio Fontana, 2021/02/10
[RFC v17 14/14] i386: split seg_helper into user-only and softmmu parts, Claudio Fontana, 2021/02/10
Re: [RFC v17 00/14] i386 cleanup PART 2, no-reply, 2021/02/11