Re: [PATCH v2 10/42] esp: introduce esp_get_stc()

[Mark Cave-Ayland]

On 10/02/2021 22:33, Philippe Mathieu-Daudé wrote:

> On 2/9/21 8:29 PM, Mark Cave-Ayland wrote:
> > This simplifies reading the STC register value without having to manually shift
> > each individual 8-bit value.
>
> If possible repeat the subject so the sentence is easier to understand.

I've always read commit messages as summary followed detail, so I've tended to avoid 
repetition if the context is obvious from the summary (a quick glance through my 
inbox suggest that quite a few authors also do the same).

Perhaps adding in the word "function" would help readability here, e.g. "This 
function simplifies reading the STC register value..."?

> > Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > ---
> >   hw/scsi/esp.c | 15 ++++++++++++---
> >   1 file changed, 12 insertions(+), 3 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


ATB,

Mark.