qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 10/35] Hexagon (target/hexagon) instruction and packet typ


From: Richard Henderson
Subject: Re: [PATCH v8 10/35] Hexagon (target/hexagon) instruction and packet types
Date: Sun, 14 Feb 2021 09:21:00 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 2/7/21 9:46 PM, Taylor Simpson wrote:
> +    uint32_t extension_valid:1;   /* Has a constant extender attached */
> +    uint32_t which_extended:1;    /* If has an extender, which immediate */
> +    uint32_t is_endloop:1;   /* This is an end of loop */
...

> +    uint32_t pkt_has_cof:1;          /* Has any change-of-flow */
> +    uint32_t pkt_has_endloop:1;
> +
> +    uint32_t pkt_has_dczeroa:1;
> +
> +    uint32_t pkt_has_store_s0:1;
> +    uint32_t pkt_has_store_s1:1;

Any reason not to use bool?

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]