qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 12/42] target/mips/tx79: Move PCPYLD / PCPYUD opcodes to


From: Philippe Mathieu-Daudé
Subject: Re: [RFC PATCH 12/42] target/mips/tx79: Move PCPYLD / PCPYUD opcodes to decodetree
Date: Mon, 15 Feb 2021 17:58:58 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 2/15/21 5:28 PM, Richard Henderson wrote:
> On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote:
>> +    if (a->rs == 0) {
>> +        tcg_gen_movi_i64(cpu_gpr_hi[a->rd], 0);
>> +    } else {
>> +        tcg_gen_mov_i64(cpu_gpr_hi[a->rd], cpu_gpr[a->rs]);
>> +    }
>> +
>> +    if (a->rt == 0) {
>> +        tcg_gen_movi_i64(cpu_gpr[a->rd], 0);
>> +    } else if (a->rd != a->rt) {
>> +        tcg_gen_mov_i64(cpu_gpr[a->rd], cpu_gpr[a->rt]);
>> +    }
> 
> Use gen_load_gpr.

This is code movement, but I'll clean in a previous patch.

> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]