Re: [PATCH 15/22] Acceptance Tests: move useful ssh methods to base class

[Willian Rampazzo]

On Wed, Feb 3, 2021 at 2:24 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> Both the virtiofs submounts and the linux ssh mips malta tests
> contains useful methods related to ssh that deserve to be made
> available to other tests.  Let's move them to the base LinuxTest
> class.
>
> The method that helps with setting up an ssh connection will now
> support both key and password based authentication, defaulting to key
> based.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  tests/acceptance/avocado_qemu/__init__.py | 49 ++++++++++++++++++++++-
>  tests/acceptance/linux_ssh_mips_malta.py  | 38 ++----------------
>  tests/acceptance/virtiofs_submounts.py    | 36 -----------------
>  3 files changed, 51 insertions(+), 72 deletions(-)
>

Here I bring back my comment from patch 14, having a common place for
test specific classes would bring a better organization to the code.
Anyway,

Reviewed-by: Willian Rampazzo <willianr@redhat.com>