Re: [PATCH v6 19/19] qapi/introspect.py: add SchemaMetaType enum

[Markus Armbruster]

John Snow <jsnow@redhat.com> writes:

> On 2/16/21 4:24 AM, Markus Armbruster wrote:
>> John Snow <jsnow@redhat.com> writes:
>> 
>>> Follows the qapi/introspect.py definition of the same; this adds a more
>>> precise typing to _gen_tree's mtype parameter.
>>>
>>> NB: print(SchemaMetaType.BUILTIN) would produce the string
>>> "SchemaMetaType.BUILTIN", but when using format strings (.format or 
>>> f-strings),
>>> it relies on the __format__ method defined in the Enum class, which uses the
>>> "value" of the enum instead, producing the string "builtin".
>>>
>>> For consistency with old-style format strings (which simply call the
>>> __str__ method of an object), a __str__ dunder is added, though it is
>>> not actually used here in this code.
>>>
>>> Signed-off-by: John Snow <jsnow@redhat.com>
[...]
>> Gain: _gen_tree()'s second argument's type now serves as documentation,
>> and passing crap to it becomes harder.
>> 
>> Gut feeling: too much notational overhead for too little gain.
>> 
>> Opinions?
>> 
>
> No strong feelings one way or the other, honestly. I wrote this mostly 
> to see how much the overhead would be based on your comment about the 
> loose typing of meta-type as str.
>
> If it's too much for too little for you, I'm okay without it too.

Let's put it aside for now.