Re: [PULL 00/40] target-arm queue

[no-reply]

Patchew URL: 
20210216161658.29881-1-peter.maydell@linaro.org/">https://patchew.org/QEMU/20210216161658.29881-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210216161658.29881-1-peter.maydell@linaro.org
Subject: [PULL 00/40] target-arm queue

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   8ba4bca..1854322  master     -> master
 - [tag update]      
patchew/1613447214-81951-1-git-send-email-bmeng.cn@gmail.com -> 
patchew/1613447214-81951-1-git-send-email-bmeng.cn@gmail.com
 - [tag update]      patchew/20210216150225.27996-1-bmeng.cn@gmail.com -> 
patchew/20210216150225.27996-1-bmeng.cn@gmail.com
 * [new tag]         patchew/20210216161658.29881-1-peter.maydell@linaro.org -> 
patchew/20210216161658.29881-1-peter.maydell@linaro.org
Switched to a new branch 'test'
e4a74dd tests/qtests: Add npcm7xx emc model test
ef5ca04 hw/arm: Add npcm7xx emc model
a8141fd hw/net: Add npcm7xx emc model
e8ae688 MAINTAINERS: add myself maintainer for the clock framework
ca69e95 hw/i2c: Implement NPCM7XX SMBus Module FIFO Mode
8f4c59b hw/i2c: Add a QTest for NPCM7XX SMBus Device
806c10b hw/arm: Add I2C sensors and EEPROM for GSJ machine
3e41e58 hw/arm: Add I2C sensors for NPCM750 eval board
f443f39 hw/i2c: Implement NPCM7XX SMBus Module Single Mode
4ec42db tests/tcg/aarch64: Add mte smoke tests
eab8c0d target/arm: Enable MTE for user-only
ee64e58 target/arm: Add allocation tag storage for user mode
26f9bcc linux-user/aarch64: Signal SEGV_MTEAERR for async tag check error
22e3b7a linux-user/aarch64: Signal SEGV_MTESERR for sync tag check fault
23bc2fc linux-user/aarch64: Pass syndrome to EXC_*_ABORT
275afc8 target/arm: Split out syndrome.h from internals.h
2e2df23 linux-user/aarch64: Implement PROT_MTE
894a6c8 linux-user/aarch64: Implement PR_MTE_TCF and PR_MTE_TAG
480c72b target/arm: Use the proper TBI settings for linux-user
e6e7bba target/arm: Improve gen_top_byte_ignore
e1a6d61 linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE
468fceb linux-user: Handle tags in lock_user/unlock_user
60d9091 linux-user: Fix types in uaccess.c
a929285 linux-user: Move lock_user et al out of line
8357b24 linux-user: Use cpu_untagged_addr in access_ok; split out *_untagged
c9af469 exec: Rename guest_{addr,range}_valid to *_untagged
710dbf7 linux-user: Use guest_range_valid in access_ok
fa8f259 linux-user: Explicitly untag memory management syscalls
9a505ec exec: Use cpu_untagged_addr in g2h; split out g2h_untagged
5a362f1 exec: Introduce cpu_untagged_addr
989aa41 linux-user: Fix guest_addr_valid vs reserved_va
f2c5d48 linux-user: Do not use guest_addr_valid for h2g_valid
fd69d91 bsd-user: Tidy VERIFY_READ/VERIFY_WRITE
f7c5dd3 linux-user: Tidy VERIFY_READ/VERIFY_WRITE
f79c274 linux-user: Check for overflow in access_ok
118dcc2 exec: Improve types for guest_addr_valid
b4b1e9e exec: Use uintptr_t in cpu_ldst.h
634d08f exec: Use uintptr_t for guest_base
816dc33 linux-user: Introduce PAGE_ANON
5937edb tcg: Introduce target-specific page data for user-only

=== OUTPUT BEGIN ===
1/40 Checking commit 5937edb5cd24 (tcg: Introduce target-specific page data for 
user-only)
2/40 Checking commit 816dc337fa18 (linux-user: Introduce PAGE_ANON)
3/40 Checking commit 634d08f702e8 (exec: Use uintptr_t for guest_base)
4/40 Checking commit b4b1e9e96ba6 (exec: Use uintptr_t in cpu_ldst.h)
5/40 Checking commit 118dcc23c7f6 (exec: Improve types for guest_addr_valid)
6/40 Checking commit f79c2743ca73 (linux-user: Check for overflow in access_ok)
7/40 Checking commit f7c5dd3bf085 (linux-user: Tidy VERIFY_READ/VERIFY_WRITE)
8/40 Checking commit fd69d91cf424 (bsd-user: Tidy VERIFY_READ/VERIFY_WRITE)
9/40 Checking commit f2c5d485c628 (linux-user: Do not use guest_addr_valid for 
h2g_valid)
10/40 Checking commit 989aa4162def (linux-user: Fix guest_addr_valid vs 
reserved_va)
11/40 Checking commit 5a362f10dbdf (exec: Introduce cpu_untagged_addr)
12/40 Checking commit 9a505ecc2ec7 (exec: Use cpu_untagged_addr in g2h; split 
out g2h_untagged)
ERROR: braces {} are necessary for all arms of this statement
#448: FILE: bsd-user/qemu.h:379:
+    if (host_ptr == g2h_untagged(guest_addr))
[...]

ERROR: braces {} are necessary for all arms of this statement
#705: FILE: linux-user/mmap.c:222:
+        if (pread(fd, g2h_untagged(start), end - start, offset) == -1)
[...]

ERROR: braces {} are necessary for all arms of this statement
#867: FILE: linux-user/qemu.h:669:
+    if (host_ptr == g2h_untagged(guest_addr))
[...]

total: 3 errors, 0 warnings, 946 lines checked

Patch 12/40 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/40 Checking commit fa8f25901088 (linux-user: Explicitly untag memory 
management syscalls)
14/40 Checking commit 710dbf7fae01 (linux-user: Use guest_range_valid in 
access_ok)
15/40 Checking commit c9af469bd88f (exec: Rename guest_{addr,range}_valid to 
*_untagged)
16/40 Checking commit 8357b248fccb (linux-user: Use cpu_untagged_addr in 
access_ok; split out *_untagged)
ERROR: braces {} are necessary for all arms of this statement
#34: FILE: linux-user/elfload.c:3513:
+    if (!access_ok_untagged(VERIFY_READ, vma->vma_start, TARGET_PAGE_SIZE))
[...]

total: 1 errors, 0 warnings, 108 lines checked

Patch 16/40 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/40 Checking commit a9292859a2b0 (linux-user: Move lock_user et al out of 
line)
ERROR: externs should be avoided in .c files
#122: FILE: linux-user/uaccess.c:29:
+void unlock_user(void *host_ptr, abi_ulong guest_addr, long len);

total: 1 errors, 0 warnings, 116 lines checked

Patch 17/40 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/40 Checking commit 60d909188300 (linux-user: Fix types in uaccess.c)
ERROR: externs should be avoided in .c files
#91: FILE: linux-user/uaccess.c:29:
+void unlock_user(void *host_ptr, abi_ulong guest_addr, size_t len);

total: 1 errors, 0 warnings, 149 lines checked

Patch 18/40 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

19/40 Checking commit 468fceb77daf (linux-user: Handle tags in 
lock_user/unlock_user)
20/40 Checking commit e1a6d6190a49 (linux-user/aarch64: Implement 
PR_TAGGED_ADDR_ENABLE)
21/40 Checking commit e6e7bba446e8 (target/arm: Improve gen_top_byte_ignore)
22/40 Checking commit 480c72b81498 (target/arm: Use the proper TBI settings for 
linux-user)
23/40 Checking commit 894a6c8898f6 (linux-user/aarch64: Implement PR_MTE_TCF 
and PR_MTE_TAG)
24/40 Checking commit 2e2df23df841 (linux-user/aarch64: Implement PROT_MTE)
25/40 Checking commit 275afc868326 (target/arm: Split out syndrome.h from 
internals.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#285: 
new file mode 100644

total: 0 errors, 1 warnings, 530 lines checked

Patch 25/40 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/40 Checking commit 23bc2fcf397f (linux-user/aarch64: Pass syndrome to 
EXC_*_ABORT)
27/40 Checking commit 22e3b7ae944b (linux-user/aarch64: Signal SEGV_MTESERR for 
sync tag check fault)
28/40 Checking commit 26f9bcca0855 (linux-user/aarch64: Signal SEGV_MTEAERR for 
async tag check error)
29/40 Checking commit ee64e58892cf (target/arm: Add allocation tag storage for 
user mode)
30/40 Checking commit eab8c0de2221 (target/arm: Enable MTE for user-only)
31/40 Checking commit 4ec42dbbc95e (tests/tcg/aarch64: Add mte smoke tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

ERROR: trailing statements should be on next line
#179: FILE: tests/tcg/aarch64/mte-3.c:50:
+    while (1);

ERROR: braces {} are necessary for all arms of this statement
#179: FILE: tests/tcg/aarch64/mte-3.c:50:
+    while (1);
[...]

ERROR: use qemu_real_host_page_size instead of getpagesize()
#217: FILE: tests/tcg/aarch64/mte-4.c:31:
+    size_t size = getpagesize() * 4;

total: 3 errors, 1 warnings, 251 lines checked

Patch 31/40 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

32/40 Checking commit f443f39eb0a3 (hw/i2c: Implement NPCM7XX SMBus Module 
Single Mode)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#175: 
new file mode 100644

total: 0 errors, 1 warnings, 1018 lines checked

Patch 32/40 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/40 Checking commit 3e41e58f11f2 (hw/arm: Add I2C sensors for NPCM750 eval 
board)
34/40 Checking commit 806c10b3584f (hw/arm: Add I2C sensors and EEPROM for GSJ 
machine)
35/40 Checking commit 8f4c59b4515c (hw/i2c: Add a QTest for NPCM7XX SMBus 
Device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 359 lines checked

Patch 35/40 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/40 Checking commit ca69e95f898f (hw/i2c: Implement NPCM7XX SMBus Module FIFO 
Mode)
37/40 Checking commit e8ae688375e5 (MAINTAINERS: add myself maintainer for the 
clock framework)
38/40 Checking commit a8141fd3e105 (hw/net: Add npcm7xx emc model)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1170 lines checked

Patch 38/40 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
39/40 Checking commit ef5ca04a3345 (hw/arm: Add npcm7xx emc model)
40/40 Checking commit e4a74dd53d8e (tests/qtests: Add npcm7xx emc model test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#493: FILE: tests/qtest/npcm7xx_emc-test.c:457:
+             0 /* padding enable = 0 */);

WARNING: Block comments use a leading /* on a separate line
#506: FILE: tests/qtest/npcm7xx_emc-test.c:470:
+             0 /* length filled in later */);

WARNING: Block comments use a leading /* on a separate line
#605: FILE: tests/qtest/npcm7xx_emc-test.c:569:
+                                       /*is_tx=*/true));

WARNING: Block comments use a leading /* on a separate line
#646: FILE: tests/qtest/npcm7xx_emc-test.c:610:
+         0   /* length (filled in later) */);

WARNING: Block comments use a leading /* on a separate line
#724: FILE: tests/qtest/npcm7xx_emc-test.c:688:
+        g_assert_true(emc_wait_irq(qts, mod, RX_STEP_COUNT, /*is_tx=*/false));

WARNING: Block comments use a leading /* on a separate line
#798: FILE: tests/qtest/npcm7xx_emc-test.c:762:
+    g_assert_true(emc_wait_irq(qts, mod, RX_STEP_COUNT, /*is_tx=*/false));

WARNING: Block comments use a leading /* on a separate line
#840: FILE: tests/qtest/npcm7xx_emc-test.c:804:
+    emc_send_verify(qts, td->module, test_sockets[0], /*with_irq=*/false);

WARNING: Block comments use a leading /* on a separate line
#841: FILE: tests/qtest/npcm7xx_emc-test.c:805:
+    emc_send_verify(qts, td->module, test_sockets[0], /*with_irq=*/true);

WARNING: Block comments use a leading /* on a separate line
#865: FILE: tests/qtest/npcm7xx_emc-test.c:829:
+    emc_recv_verify(qts, td->module, test_sockets[0], /*with_irq=*/false);

WARNING: Block comments use a leading /* on a separate line
#866: FILE: tests/qtest/npcm7xx_emc-test.c:830:
+    emc_recv_verify(qts, td->module, test_sockets[0], /*with_irq=*/true);

total: 0 errors, 11 warnings, 869 lines checked

Patch 40/40 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210216161658.29881-1-peter.maydell@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210216161658.29881-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com