qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 30/42] esp: add 4 byte PDMA read and write transfers


From: Mark Cave-Ayland
Subject: Re: [PATCH v2 30/42] esp: add 4 byte PDMA read and write transfers
Date: Tue, 16 Feb 2021 21:36:26 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 16/02/2021 07:30, Philippe Mathieu-Daudé wrote:

Are you planning to review any more of this series? I'm keen to put out
a (hopefully final) v3 soon, but I'll hold off for little while if you
want more time to look over the remaining patches.

I talked about this series with Laurent on Sunday, asking him for
review help ;) I don't remember if there is any big comment to
address in patches 1-14. If not I can review the missing ones
there today and you could send directly a pull request for this
first set, then send the rest as v3. Does that help?
For the rest I doubt having time to focus before Friday.

I'd prefer to merge the entire series, since there is more than one migration compatibility break for the q800 machine and I think it would be almost impossible to ensure that all test images didn't regress at some point until all patches have been applied.

I should probably add that I expanded the test suite to booting 10 images from v1 to v2 across a mix of SPARC, m68k, x86_64 and hppa including both commercial and free OSs.


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]