[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 32/71] tcg/tci: Reduce qemu_ld/st TCGMemOpIdx operand to 32-bi
From: |
Richard Henderson |
Subject: |
[PATCH v4 32/71] tcg/tci: Reduce qemu_ld/st TCGMemOpIdx operand to 32-bits |
Date: |
Wed, 17 Feb 2021 12:19:57 -0800 |
We are currently using the "natural" size routine, which
uses 64-bits on a 64-bit host. The TCGMemOpIdx operand
has 11 bits, so we can safely reduce to 32-bits.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/tci.c | 8 ++++----
tcg/tci/tcg-target.c.inc | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tcg/tci.c b/tcg/tci.c
index 3ce2b72316..583059f319 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -838,7 +838,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
*env,
case INDEX_op_qemu_ld_i32:
t0 = *tb_ptr++;
taddr = tci_read_ulong(regs, &tb_ptr);
- oi = tci_read_i(&tb_ptr);
+ oi = tci_read_i32(&tb_ptr);
switch (get_memop(oi) & (MO_BSWAP | MO_SSIZE)) {
case MO_UB:
tmp32 = qemu_ld_ub;
@@ -875,7 +875,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
*env,
t1 = *tb_ptr++;
}
taddr = tci_read_ulong(regs, &tb_ptr);
- oi = tci_read_i(&tb_ptr);
+ oi = tci_read_i32(&tb_ptr);
switch (get_memop(oi) & (MO_BSWAP | MO_SSIZE)) {
case MO_UB:
tmp64 = qemu_ld_ub;
@@ -924,7 +924,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
*env,
case INDEX_op_qemu_st_i32:
t0 = tci_read_rval(regs, &tb_ptr);
taddr = tci_read_ulong(regs, &tb_ptr);
- oi = tci_read_i(&tb_ptr);
+ oi = tci_read_i32(&tb_ptr);
switch (get_memop(oi) & (MO_BSWAP | MO_SIZE)) {
case MO_UB:
qemu_st_b(t0);
@@ -948,7 +948,7 @@ uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState
*env,
case INDEX_op_qemu_st_i64:
tmp64 = tci_read_r64(regs, &tb_ptr);
taddr = tci_read_ulong(regs, &tb_ptr);
- oi = tci_read_i(&tb_ptr);
+ oi = tci_read_i32(&tb_ptr);
switch (get_memop(oi) & (MO_BSWAP | MO_SIZE)) {
case MO_UB:
qemu_st_b(tmp64);
diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc
index 640407b4a8..6c187a25cc 100644
--- a/tcg/tci/tcg-target.c.inc
+++ b/tcg/tci/tcg-target.c.inc
@@ -550,7 +550,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, const
TCGArg *args,
if (TARGET_LONG_BITS > TCG_TARGET_REG_BITS) {
tcg_out_r(s, *args++);
}
- tcg_out_i(s, *args++);
+ tcg_out32(s, *args++);
break;
case INDEX_op_qemu_ld_i64:
@@ -563,7 +563,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, const
TCGArg *args,
if (TARGET_LONG_BITS > TCG_TARGET_REG_BITS) {
tcg_out_r(s, *args++);
}
- tcg_out_i(s, *args++);
+ tcg_out32(s, *args++);
break;
case INDEX_op_mb:
--
2.25.1
- [PATCH v4 20/71] tcg/tci: Split out tci_args_rrr, (continued)
- [PATCH v4 20/71] tcg/tci: Split out tci_args_rrr, Richard Henderson, 2021/02/17
- [PATCH v4 22/71] tcg/tci: Split out tci_args_l, Richard Henderson, 2021/02/17
- [PATCH v4 24/71] tcg/tci: Split out tci_args_rrcl and tci_args_rrrrcl, Richard Henderson, 2021/02/17
- [PATCH v4 26/71] tcg/tci: Reuse tci_args_l for calls., Richard Henderson, 2021/02/17
- [PATCH v4 23/71] tcg/tci: Split out tci_args_rrrrrc, Richard Henderson, 2021/02/17
- [PATCH v4 25/71] tcg/tci: Split out tci_args_ri and tci_args_rI, Richard Henderson, 2021/02/17
- [PATCH v4 31/71] tcg/tci: Clean up deposit operations, Richard Henderson, 2021/02/17
- [PATCH v4 30/71] tcg/tci: Split out tci_args_rrrr, Richard Henderson, 2021/02/17
- [PATCH v4 27/71] tcg/tci: Reuse tci_args_l for exit_tb, Richard Henderson, 2021/02/17
- [PATCH v4 28/71] tcg/tci: Reuse tci_args_l for goto_tb, Richard Henderson, 2021/02/17
- [PATCH v4 32/71] tcg/tci: Reduce qemu_ld/st TCGMemOpIdx operand to 32-bits,
Richard Henderson <=
- [PATCH v4 33/71] tcg/tci: Split out tci_args_{rrm,rrrm,rrrrm}, Richard Henderson, 2021/02/17
- [PATCH v4 29/71] tcg/tci: Split out tci_args_rrrrrr, Richard Henderson, 2021/02/17
- [PATCH v4 35/71] tcg/tci: Remove tci_disas, Richard Henderson, 2021/02/17
- [PATCH v4 34/71] tcg/tci: Hoist op_size checking into tci_args_*, Richard Henderson, 2021/02/17
- [PATCH v4 36/71] tcg/tci: Implement the disassembler properly, Richard Henderson, 2021/02/17
- [PATCH v4 37/71] tcg: Build ffi data structures for helpers, Richard Henderson, 2021/02/17
- [PATCH v4 38/71] tcg/tci: Use ffi for calls, Richard Henderson, 2021/02/17
- [PATCH v4 39/71] tcg/tci: Improve tcg_target_call_clobber_regs, Richard Henderson, 2021/02/17
- [PATCH v4 40/71] tcg/tci: Move call-return regs to end of tcg_target_reg_alloc_order, Richard Henderson, 2021/02/17
- [PATCH v4 41/71] tcg/tci: Push opcode emit into each case, Richard Henderson, 2021/02/17