[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/71] tcg/tci: Remove tci_read_r8
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v4 05/71] tcg/tci: Remove tci_read_r8 |
|
Date: |
Fri, 19 Feb 2021 01:03:07 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/19/21 12:33 AM, Richard Henderson wrote:
> On 2/18/21 3:11 PM, Philippe Mathieu-Daudé wrote:
>>> @@ -533,7 +520,7 @@ uintptr_t QEMU_DISABLE_CFI
>>> tcg_qemu_tb_exec(CPUArchState *env,
>>> tci_write_reg(regs, t0, *(uint32_t *)(t1 + t2));
>>> break;
>>> CASE_32_64(st8)
>>> - t0 = tci_read_r8(regs, &tb_ptr);
>>> + t0 = tci_read_r(regs, &tb_ptr);
>>
>> No need for tb_ptr++ here?
>
> Done in tcg_read_b, called by tci_read_r.
Doh I missed it is done in tci_read_r() indeed.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v4 00/71] TCI fixes and cleanups, Richard Henderson, 2021/02/17
- [PATCH v4 01/71] tcg/tci: Use exec/cpu_ldst.h interfaces, Richard Henderson, 2021/02/17
- [PATCH v4 02/71] tcg: Split out tcg_raise_tb_overflow, Richard Henderson, 2021/02/17
- [PATCH v4 03/71] tcg: Manage splitwx in tc_ptr_to_region_tree by hand, Richard Henderson, 2021/02/17
- [PATCH v4 04/71] tcg/tci: Merge identical cases in generation, Richard Henderson, 2021/02/17
- [PATCH v4 05/71] tcg/tci: Remove tci_read_r8, Richard Henderson, 2021/02/17
- [PATCH v4 06/71] tcg/tci: Remove tci_read_r8s, Richard Henderson, 2021/02/17
- [PATCH v4 07/71] tcg/tci: Remove tci_read_r16, Richard Henderson, 2021/02/17
- [PATCH v4 08/71] tcg/tci: Remove tci_read_r16s, Richard Henderson, 2021/02/17
- [PATCH v4 09/71] tcg/tci: Remove tci_read_r32, Richard Henderson, 2021/02/17
- [PATCH v4 10/71] tcg/tci: Remove tci_read_r32s, Richard Henderson, 2021/02/17