[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ui/cocoa: Fix mouse association state
From: |
Peter Maydell |
Subject: |
Re: [PATCH] ui/cocoa: Fix mouse association state |
Date: |
Sun, 21 Feb 2021 19:41:16 +0000 |
On Sun, 21 Feb 2021 at 18:31, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
This is hard to review without a commit message that describes:
* what the problem is that the change is trying to fix
* what the change is doing
* why this fixes the problem
Without a commit message you're asking code reviewers to
reverse-engineer your intentions from the code change,
which is a lot more work than if you told us up front :-)
thanks
-- PMM