[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 1/2] drivers/misc: sysgenid: add system generation id driv
|
From: |
Greg KH |
|
Subject: |
Re: [PATCH v6 1/2] drivers/misc: sysgenid: add system generation id driver |
|
Date: |
Mon, 22 Feb 2021 10:53:06 +0100 |
On Mon, Feb 22, 2021 at 11:41:25AM +0200, Adrian Catangiu wrote:
> The driver also generates a `SYSGENID=%u` uevent containing the new
> system generation counter/id value every time it changes. Unlike the
> filesystem interface, the uevent has no synchronization guarantees
> therefore it should not be used by any sensitive system components.
No, please no. It is not ok to start sending random uevents all the
time to userspace for individual drivers like this. Especially for a
misc device.
As you say "has no synchromization guarantees", then why use it at all?
Please drop it.
thanks,
greg k-h