Re: [PATCH v6 09/12] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require)

[Paolo Bonzini]

On 22/02/21 12:57, David Hildenbrand wrote:
>  
> -/*
> - * If positive, discarding RAM is disabled. If negative, discarding RAM is
> - * required to work and cannot be disabled.
> - */
> -static int ram_block_discard_disabled;
> +static unsigned int ram_block_discard_requirers;
> +static unsigned int ram_block_discard_disablers;

Requirer is not an English word, so perhaps use required_cnt and 
disabled_cnt?

Also, uncoordinated require is unused, and therefore uncoordinated 
disable is also never going to block anything.  Does it make sense to 
keep it in the API?

Paolo