[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/5] hw/block/nvme: report non-mdts command size limit for
From: |
Klaus Jensen |
Subject: |
Re: [PATCH v2 5/5] hw/block/nvme: report non-mdts command size limit for dsm |
Date: |
Mon, 22 Feb 2021 22:12:22 +0100 |
On Feb 23 05:55, Keith Busch wrote:
> On Mon, Feb 22, 2021 at 07:47:59PM +0100, Klaus Jensen wrote:
> > +typedef struct NvmeIdCtrlNvm {
> > + uint8_t vsl;
> > + uint8_t wzsl;
> > + uint8_t wusl;
> > + uint8_t dmrl;
> > + uint32_t dmrsl;
> > + uint64_t dmsl;
> > + uint8_t rsvd16[4080];
> > +} NvmeIdCtrlNvm;
>
> TP 4040a still displays these fields with preceding '...' indicating
> something comes before this. Is that just left-over from the integration
> for TBD offsets, or is there something that still hasn't been accounted
> for?
Good question.
But since the TBDs have been assigned I believe it is just a left-over.
I must admit that I have not cross checked this with all other TPs, but
AFAIK this is the only ratified TP that adds something to the
NVM-specific identify controller data structure.
signature.asc
Description: PGP signature
- [PATCH v2 0/5] hw/block/nvme: misc fixes, Klaus Jensen, 2021/02/22
- [PATCH v2 2/5] hw/block/nvme: add identify trace event, Klaus Jensen, 2021/02/22
- [PATCH v2 1/5] hw/block/nvme: remove unnecessary endian conversion, Klaus Jensen, 2021/02/22
- [PATCH v2 3/5] hw/block/nvme: fix potential compilation error, Klaus Jensen, 2021/02/22
- [PATCH v2 4/5] hw/block/nvme: add trace event for zone read check, Klaus Jensen, 2021/02/22
- [PATCH v2 5/5] hw/block/nvme: report non-mdts command size limit for dsm, Klaus Jensen, 2021/02/22