[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v1 05/38] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG
From: |
Claudio Fontana |
Subject: |
Re: [RFC v1 05/38] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG |
Date: |
Tue, 23 Feb 2021 09:46:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 2/22/21 4:54 PM, Richard Henderson wrote:
> On 2/22/21 12:31 AM, Claudio Fontana wrote:
>> actually this is a fix for an error I introduced when adding TCGOps:
>>
>> arm_cpu_exec_interrupt should be wrapped in the ifdef, as it uses tcg_ops,
>> which is TCG-only.
>> Maybe I should extract this and make it a standalone fix.
>>
>> Currently, there is no real issue because the non-TCG build is not working
>> for ARM anyway,
>> and that's why the issue went undetected.
>
> If it doesn't cause a current problem, then let's not bother with a standalone
> patch. But I wouldn't bother with the ifdef either, but instead move the
> function to an appropriate file.
>
>
> r~
>
Yes, agree.
Ciao,
Claudio