qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 4/4] Jobs based on custom runners: add job definitions for


From: Cleber Rosa
Subject: Re: [PATCH v5 4/4] Jobs based on custom runners: add job definitions for QEMU's machines
Date: Wed, 24 Feb 2021 10:54:06 -0500

On Wed, Feb 24, 2021 at 01:00:54PM +0100, Philippe Mathieu-Daudé wrote:
> On 2/23/21 7:25 PM, Cleber Rosa wrote:
> > On Tue, Feb 23, 2021 at 03:56:19PM +0000, Daniel P. Berrangé wrote:
> >>
> >> Urgh, well that's a big problem. We certainly don't want *anything* being
> >> placed on the custom runners without explicit opt-in, otherwise jobs run
> >> in the main repo have a different environment from when users run on their
> >> personal forks.
> >>
> >> IOW, we need anti-affinity against our custom runners really.
> >>
> > 
> > I'm assuming Phil missed that documentation, because that's a
> > non-issue, really.
> > 
> > Just unchecking the "Run untagged jobs" check box on the runner
> > configuration makes sure that the custom runners won't pickup any jobs
> > not *specifically* tagged for them.
> 
> Can we explicit this when registering the runner instead of having to
> access the WebUI?
> 
> $ gitlab-runner register --help
> 
>    --run-untagged
>      Register to run untagged builds; defaults to 'true'
>      when 'tag-list' is empty [$REGISTER_RUN_UNTAGGED]
> 

Sure thing, I will change the default behavior on the next version.

Thanks,
- Cleber.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]