Re: [PATCH 2/2] gitlab-ci.yml: Add jobs to test CFI flags

[Daniele Buono]

On 2/23/2021 3:11 AM, Paolo Bonzini wrote:
> On 23/02/21 00:01, Daniele Buono wrote:
> > +# Set JOBS=1 because this requires LTO and ld consumes a large amount 
> > of memory.
> > +# On gitlab runners, default JOBS of 2 sometimes end up calling 2 lds 
> > concurrently
> > +# and triggers an Out-Of-Memory error
>
> Does it make sense to test only one target instead?

I'd prefer grouping multiple targets per job so that the number of jobs 
doesn't explode, and stopping ninja from linking in parallel does solve 
the issue.

There's also the issue that tests are also compiled here so you may end
up with two linkers anyway. However the chance that this will end up in
an out-of-memory error is quite smaller (possibly zero) since tests
don't link that many object files together.

> > +# Because of how slirp is used in QEMU, we need to have CFI also on 
> > libslirp.
> > +# System-wide version in fedora is not compiled with CFI so we 
> > recompile it using
> > +# -enable-slirp=git
>
> Can you explain what you mean, and perhaps add a check or warning for 
> incompatible settings?

Certainly. The issue here is that there is a function in libslirp that
is used as callbacks for QEMU Timers: ra_timer_handler
(There may be others, but of this one I'm sure because I traced it).

This is not an issue when you compile slirp with qemu, since the whole
library now has CFI informations and is statically linked in the QEMU
binary. It becomes an issue if you are dynamically linking a system-wide
libslirp, as it happens on Fedora.

I'd be happy to add a check on configure/meson that ends the configure
step with an error when this happens, but that would technically be an
independent patch that I'd work on in parallel to this one.
I would prefer to not automatically select the git-based libslirp
because that may go unnoticed when configuring.

> Paolo