Re: [PATCH v22 00/17] i386 cleanup PART 2

[Philippe Mathieu-Daudé]

On 2/24/21 2:34 PM, Claudio Fontana wrote:

> Claudio Fontana (17):
>   i386: split cpu accelerators from cpu.c, using AccelCPUClass
>   cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn
>   accel: introduce new accessor functions
>   target/i386: fix host_cpu_adjust_phys_bits error handling
>   accel-cpu: make cpu_realizefn return a bool
>   meson: add target_user_arch
>   i386: split off sysemu-only functionality in tcg-cpu
>   i386: split smm helper (sysemu)
>   i386: split tcg excp_helper into sysemu and user parts
>   i386: move TCG btp_helper into sysemu/
>   i386: split misc helper into user and sysemu parts
>   i386: separate fpu_helper into user and sysemu parts
>   i386: split svm_helper into sysemu and stub-only user
>   i386: split seg_helper into user-only and sysemu parts
>   i386: split off sysemu part of cpu.c
>   i386: gdbstub: only write CR0/CR2/CR3/EFER for SOFTMMU
>   i386: move cpu_load_efer into sysemu-only section of cpu.h
> 
>  meson.build                               |   5 +
>  include/hw/core/accel-cpu.h               |   2 +-
>  include/qemu/accel.h                      |  13 +
>  target/i386/cpu-internal.h                |  70 ++
>  target/i386/cpu.h                         |  54 +-
>  target/i386/helper.h                      |  11 +
>  target/i386/host-cpu.h                    |  19 +
>  target/i386/kvm/kvm-cpu.h                 |  41 ++
>  target/i386/tcg/helper-tcg.h              |   8 +
>  target/i386/tcg/seg_helper.h              |  66 ++
>  target/i386/tcg/tcg-cpu.h                 |  21 +-
>  accel/accel-common.c                      |  19 +
>  cpu.c                                     |   5 +-
>  hw/i386/pc_piix.c                         |   1 +
>  target/i386/cpu-softmmu.c                 | 352 ++++++++++
>  target/i386/cpu.c                         | 780 ++--------------------
>  target/i386/gdbstub.c                     |  16 +
>  target/i386/host-cpu.c                    | 204 ++++++
>  target/i386/hvf/hvf-cpu.c                 |  68 ++
>  target/i386/kvm/kvm-cpu.c                 | 151 +++++
>  target/i386/kvm/kvm.c                     |   3 +-
>  target/i386/tcg/bpt_helper.c              | 276 --------
>  target/i386/tcg/excp_helper.c             | 572 ----------------
>  target/i386/tcg/fpu_helper.c              |  65 +-
>  target/i386/tcg/misc_helper.c             | 463 -------------
>  target/i386/tcg/seg_helper.c              | 237 +------
>  target/i386/tcg/sysemu/bpt_helper.c       | 293 ++++++++
>  target/i386/tcg/sysemu/excp_helper.c      | 581 ++++++++++++++++
>  target/i386/tcg/sysemu/fpu_helper.c       |  58 ++
>  target/i386/tcg/sysemu/misc_helper.c      | 438 ++++++++++++
>  target/i386/tcg/sysemu/seg_helper.c       | 125 ++++
>  target/i386/tcg/{ => sysemu}/smm_helper.c |  19 +-
>  target/i386/tcg/{ => sysemu}/svm_helper.c |  62 +-
>  target/i386/tcg/sysemu/tcg-cpu.c          |  83 +++
>  target/i386/tcg/tcg-cpu.c                 |  50 +-
>  target/i386/tcg/translate.c               |  13 +-
>  target/i386/tcg/user/excp_helper.c        |  39 ++
>  target/i386/tcg/user/fpu_helper.c         |  42 ++
>  target/i386/tcg/user/misc_helper.c        |  72 ++
>  target/i386/tcg/user/seg_helper.c         | 109 +++
>  target/i386/tcg/user/svm_stubs.c          |  76 +++
>  MAINTAINERS                               |   2 +-
>  target/alpha/meson.build                  |   3 +
>  target/arm/meson.build                    |   2 +
>  target/cris/meson.build                   |   3 +
>  target/hexagon/meson.build                |   3 +
>  target/hppa/meson.build                   |   3 +
>  target/i386/hvf/meson.build               |   1 +
>  target/i386/kvm/meson.build               |   7 +-
>  target/i386/meson.build                   |   9 +-
>  target/i386/tcg/meson.build               |   5 +-
>  target/i386/tcg/sysemu/meson.build        |  10 +
>  target/i386/tcg/user/meson.build          |   7 +
>  target/m68k/meson.build                   |   3 +
>  target/microblaze/meson.build             |   3 +
>  target/mips/meson.build                   |   3 +
>  target/nios2/meson.build                  |   3 +
>  target/openrisc/meson.build               |   3 +
>  target/ppc/meson.build                    |   3 +
>  target/riscv/meson.build                  |   3 +
>  target/s390x/meson.build                  |   3 +
>  target/sh4/meson.build                    |   3 +
>  target/sparc/meson.build                  |   3 +
>  target/tilegx/meson.build                 |   3 +
>  target/tricore/meson.build                |   3 +
>  target/xtensa/meson.build                 |   3 +
>  66 files changed, 3210 insertions(+), 2466 deletions(-)
>  create mode 100644 target/i386/cpu-internal.h
>  create mode 100644 target/i386/host-cpu.h
>  create mode 100644 target/i386/kvm/kvm-cpu.h
>  create mode 100644 target/i386/tcg/seg_helper.h
>  create mode 100644 target/i386/cpu-softmmu.c
>  create mode 100644 target/i386/host-cpu.c
>  create mode 100644 target/i386/hvf/hvf-cpu.c
>  create mode 100644 target/i386/kvm/kvm-cpu.c
>  create mode 100644 target/i386/tcg/sysemu/bpt_helper.c
>  create mode 100644 target/i386/tcg/sysemu/excp_helper.c
>  create mode 100644 target/i386/tcg/sysemu/fpu_helper.c
>  create mode 100644 target/i386/tcg/sysemu/misc_helper.c
>  create mode 100644 target/i386/tcg/sysemu/seg_helper.c
>  rename target/i386/tcg/{ => sysemu}/smm_helper.c (98%)
>  rename target/i386/tcg/{ => sysemu}/svm_helper.c (96%)
>  create mode 100644 target/i386/tcg/sysemu/tcg-cpu.c
>  create mode 100644 target/i386/tcg/user/excp_helper.c
>  create mode 100644 target/i386/tcg/user/fpu_helper.c
>  create mode 100644 target/i386/tcg/user/misc_helper.c
>  create mode 100644 target/i386/tcg/user/seg_helper.c
>  create mode 100644 target/i386/tcg/user/svm_stubs.c
>  create mode 100644 target/i386/tcg/sysemu/meson.build
>  create mode 100644 target/i386/tcg/user/meson.build

Series:
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>