Re: [PATCH v22 01/17] i386: split cpu accelerators from cpu.c, using AccelCPUClass

[Richard Henderson]

On 2/24/21 5:34 AM, Claudio Fontana wrote:
> i386 is the first user of AccelCPUClass, allowing to split
> cpu.c into:
> 
> cpu.c            cpuid and common x86 cpu functionality
> host-cpu.c       host x86 cpu functions and "host" cpu type
> kvm/kvm-cpu.c    KVM x86 AccelCPUClass
> hvf/hvf-cpu.c    HVF x86 AccelCPUClass
> tcg/tcg-cpu.c    TCG x86 AccelCPUClass
> 
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  target/i386/cpu.h           |  20 +-
>  target/i386/host-cpu.h      |  19 ++
>  target/i386/kvm/kvm-cpu.h   |  41 ++++
>  target/i386/tcg/tcg-cpu.h   |  15 --
>  hw/i386/pc_piix.c           |   1 +
>  target/i386/cpu.c           | 390 ++++--------------------------------
>  target/i386/host-cpu.c      | 201 +++++++++++++++++++
>  target/i386/hvf/hvf-cpu.c   |  68 +++++++
>  target/i386/kvm/kvm-cpu.c   | 151 ++++++++++++++
>  target/i386/kvm/kvm.c       |   3 +-
>  target/i386/tcg/tcg-cpu.c   | 113 ++++++++++-
>  MAINTAINERS                 |   2 +-
>  target/i386/hvf/meson.build |   1 +
>  target/i386/kvm/meson.build |   7 +-
>  target/i386/meson.build     |   6 +-
>  15 files changed, 651 insertions(+), 387 deletions(-)
>  create mode 100644 target/i386/host-cpu.h
>  create mode 100644 target/i386/kvm/kvm-cpu.h
>  delete mode 100644 target/i386/tcg/tcg-cpu.h
>  create mode 100644 target/i386/host-cpu.c
>  create mode 100644 target/i386/hvf/hvf-cpu.c
>  create mode 100644 target/i386/kvm/kvm-cpu.c

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~