Re: [PATCH v22 10/17] i386: move TCG btp_helper into sysemu/

[Richard Henderson]

On 2/24/21 5:34 AM, Claudio Fontana wrote:
> @@ -8074,7 +8078,9 @@ static target_ulong disas_insn(DisasContext *s, 
> CPUState *cpu)
>                  gen_svm_check_intercept(s, pc_start, SVM_EXIT_WRITE_DR0 + 
> reg);
>                  gen_op_mov_v_reg(s, ot, s->T0, rm);
>                  tcg_gen_movi_i32(s->tmp2_i32, reg);
> +#ifndef CONFIG_USER_ONLY
>                  gen_helper_set_dr(cpu_env, s->tmp2_i32, s->T0);
> +#endif /* CONFIG_USER_ONLY */
>                  gen_jmp_im(s, s->pc - s->cs_base);
>                  gen_eob(s);

Given that you need the ifdef, you might as well extend it to the entire else
of s->cpl != 0.  User-only will always have cpl == 3.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~