[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] vl: deprecate -writeconfig
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2] vl: deprecate -writeconfig |
Date: |
Thu, 25 Feb 2021 14:03:37 +0000 |
User-agent: |
Mutt/2.0.5 (2021-01-21) |
On Thu, Feb 25, 2021 at 02:13:16PM +0100, Paolo Bonzini wrote:
> The functionality of -writeconfig is limited and the code
> does not even try to detect cases where it prints incorrect
> syntax (for example if values have a quote in them, since
> qemu_config_parse does not support any kind of escaping)
> so remove it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> v1->v2: drop option from manual, mention that there is no replacement
> ---
> docs/system/deprecated.rst | 7 +++++++
> qemu-options.hx | 7 +------
> softmmu/vl.c | 1 +
> 3 files changed, 9 insertions(+), 6 deletions(-)
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index b219ce1f35..6d8393b6f7 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -3356,6 +3356,7 @@ void qemu_init(int argc, char **argv, char **envp)
> case QEMU_OPTION_writeconfig:
> {
> FILE *fp;
> + warn_report("-writeconfig is deprecated. It will go
> away in QEMU 6.2 with no replacement");
FWIW, we've rarely kept exactly to our 2 cycle plan. In practice it has
become more of a minimum bar, rather than an exact deadline. If you want
to promise death in 6.2 though I'll defer to your judgement :=)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|