[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 00/10] target/hexagon: introduce idef-parser
From: |
Alessandro Di Federico |
Subject: |
Re: [RFC PATCH 00/10] target/hexagon: introduce idef-parser |
Date: |
Thu, 25 Feb 2021 16:24:48 +0100 |
On Sun, 14 Feb 2021 13:52:25 -0800
Richard Henderson <richard.henderson@linaro.org> wrote:
> Well, first off, this fails to build with our gitlab CI.
>
> There are several problems, apart from the new bison parse.error
> option previously reported:
>
> (1) bison and flex not added to dockerfiles, so the packages are not
> available to CI.
>
> (2) idef-parser program not marked with "native: true", so we get an
> early meson error about that.
>
> (3) flex = generator() does not specify both output files, so the
> proper dependency on idef-parser.yy.h is not present.
>
> (4) idef-parser.yy.h is placed in the wrong directory, because you
> used '%option header-file="xyz"' instead of the command-line
> '--headerfile=@OUTPUT1@'. This results in an immediate compilation
> failure, because the file isn't found.
>
> (5) There's an odd mismatch in file naming, in which you have
> idef-lexer.lex.yy.c but idef-parser.yy.h. Not a bug, really, but it
> looks odd when fixing 3 & 4.
We've integrated the suggested changes and tested the v2 on the Gitlab
CI. It should now work properly.
--
Alessandro Di Federico
rev.ng
- Re: [RFC PATCH 03/10] target/hexagon: make helper functions non-static, (continued)
- [RFC PATCH 04/10] target/hexagon: introduce new helper functions, Alessandro Di Federico, 2021/02/11
- [RFC PATCH 08/10] target/hexagon: import parser for idef-parser, Alessandro Di Federico, 2021/02/11
- [RFC PATCH 10/10] target/hexagon: import additional tests, Alessandro Di Federico, 2021/02/11
- [RFC PATCH 05/10] target/hexagon: expose next PC in DisasContext, Alessandro Di Federico, 2021/02/11
- Re: [RFC PATCH 00/10] target/hexagon: introduce idef-parser, Richard Henderson, 2021/02/14
- Re: [RFC PATCH 00/10] target/hexagon: introduce idef-parser,
Alessandro Di Federico <=