Re: [PATCH v24 12/18] i386: separate fpu_helper into user and sysemu parts

[Richard Henderson]

On 2/26/21 1:49 AM, Claudio Fontana wrote:
> +/*
> + * XXX in helper_fsave() we reference GETPC(). Which is only valid when
> + * directly called from code_gen_buffer.
> + *
> + * The signature of cpu_x86_foo should be changed to add a "uintptr_t 
> retaddr"
> + * argument, the callers from linux-user/i386/signal.c must pass 0 for this
> + * new argument (no unwind required), and the helpers must do
> + *
> + * void helper_fsave(CPUX86State *env, target_ulong ptr, int data32)
> + * {
> + *    cpu_x86_fsave(env, ptr, data32, GETPC());
> + * }
> + *
> + * etc.
> + */

I'll send a patch to fix this rather than document it.

It will mean that you can't split out these little helpers to a new file, at
least not reasonably.


r~