Re: [PATCH v3 06/11] esp: ensure cmdfifo is not empty and current

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 06/11] esp: ensure cmdfifo is not empty and current_dev is

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH v3 06/11] esp: ensure cmdfifo is not empty and current_dev is non-NULL
Date:	Thu, 1 Apr 2021 10:17:16 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0

On 4/1/21 9:49 AM, Mark Cave-Ayland wrote:
> When about to execute a SCSI command, ensure that cmdfifo is not empty and
> current_dev is non-NULL. This can happen if the guest tries to execute a TI
> (Transfer Information) command without issuing one of the select commands
> first.
> 
> Buglink: https://bugs.launchpad.net/qemu/+bug/1910723
> Buglink: https://bugs.launchpad.net/qemu/+bug/1909247
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  hw/scsi/esp.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v3 03/11] esp: consolidate esp_cmdfifo_push() into esp_fifo_push(), (continued)
- [PATCH v3 04/11] esp: consolidate esp_cmdfifo_pop() into esp_fifo_pop(), Mark Cave-Ayland, 2021/04/01
  - Re: [PATCH v3 04/11] esp: consolidate esp_cmdfifo_pop() into esp_fifo_pop(), Philippe Mathieu-Daudé, 2021/04/01
- [PATCH v3 05/11] esp: introduce esp_fifo_pop_buf() and use it instead of fifo8_pop_buf(), Mark Cave-Ayland, 2021/04/01
  - Re: [PATCH v3 05/11] esp: introduce esp_fifo_pop_buf() and use it instead of fifo8_pop_buf(), Philippe Mathieu-Daudé, 2021/04/01
    - Re: [PATCH v3 05/11] esp: introduce esp_fifo_pop_buf() and use it instead of fifo8_pop_buf(), Mark Cave-Ayland, 2021/04/01
    - Re: [PATCH v3 05/11] esp: introduce esp_fifo_pop_buf() and use it instead of fifo8_pop_buf(), Philippe Mathieu-Daudé, 2021/04/01
- [PATCH v3 06/11] esp: ensure cmdfifo is not empty and current_dev is non-NULL, Mark Cave-Ayland, 2021/04/01
  - Re: [PATCH v3 06/11] esp: ensure cmdfifo is not empty and current_dev is non-NULL, Philippe Mathieu-Daudé <=
- [PATCH v3 07/11] esp: don't underflow cmdfifo in do_cmd(), Mark Cave-Ayland, 2021/04/01
  - Re: [PATCH v3 07/11] esp: don't underflow cmdfifo in do_cmd(), Philippe Mathieu-Daudé, 2021/04/01
    - Re: [PATCH v3 07/11] esp: don't underflow cmdfifo in do_cmd(), Mark Cave-Ayland, 2021/04/01
- [PATCH v3 08/11] esp: don't overflow cmdfifo in get_cmd(), Mark Cave-Ayland, 2021/04/01
  - Re: [PATCH v3 08/11] esp: don't overflow cmdfifo in get_cmd(), Philippe Mathieu-Daudé, 2021/04/01
    - Re: [PATCH v3 08/11] esp: don't overflow cmdfifo in get_cmd(), Mark Cave-Ayland, 2021/04/01
- [PATCH v3 09/11] esp: don't overflow cmdfifo if TC is larger than the cmdfifo size, Mark Cave-Ayland, 2021/04/01
- [PATCH v3 10/11] esp: don't reset async_len directly in esp_select() if cancelling request, Mark Cave-Ayland, 2021/04/01
- [PATCH v3 11/11] tests/qtest: add tests for am53c974 device, Mark Cave-Ayland, 2021/04/01
  - Re: [PATCH v3 11/11] tests/qtest: add tests for am53c974 device, Alexander Bulekov, 2021/04/01

Prev by Date: Re: [PATCH v3 04/11] esp: consolidate esp_cmdfifo_pop() into esp_fifo_pop()
Next by Date: Re: [PATCH v3 07/11] esp: don't underflow cmdfifo in do_cmd()
Previous by thread: [PATCH v3 06/11] esp: ensure cmdfifo is not empty and current_dev is non-NULL
Next by thread: [PATCH v3 07/11] esp: don't underflow cmdfifo in do_cmd()
Index(es):
- Date
- Thread