[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/9] virtio-pci: remove explicit initialization of val
From: |
Michael S. Tsirkin |
Subject: |
[PULL 5/9] virtio-pci: remove explicit initialization of val |
Date: |
Thu, 1 Apr 2021 14:03:02 -0400 |
From: Yuri Benditovich <yuri.benditovich@daynix.com>
The value is assigned later in this procedure.
Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
Message-Id: <20210315115937.14286-3-yuri.benditovich@daynix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/virtio-pci.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 4a3dcee771..c1b67cf6fc 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -1385,10 +1385,10 @@ static uint64_t virtio_pci_device_read(void *opaque,
hwaddr addr,
{
VirtIOPCIProxy *proxy = opaque;
VirtIODevice *vdev = virtio_bus_get_device(&proxy->bus);
- uint64_t val = 0;
+ uint64_t val;
if (vdev == NULL) {
- return val;
+ return 0;
}
switch (size) {
@@ -1401,6 +1401,9 @@ static uint64_t virtio_pci_device_read(void *opaque,
hwaddr addr,
case 4:
val = virtio_config_modern_readl(vdev, addr);
break;
+ default:
+ val = 0;
+ break;
}
return val;
}
--
MST
- [PULL 0/9] pc,virtio,pci: bugfixes, Michael S. Tsirkin, 2021/04/01
- [PULL 1/9] vhost-user-blk: use different event handlers on initialization, Michael S. Tsirkin, 2021/04/01
- [PULL 2/9] vhost-user-blk: perform immediate cleanup if disconnect on initialization, Michael S. Tsirkin, 2021/04/01
- [PULL 4/9] virtio-pci: add check for vdev in virtio_pci_isr_read, Michael S. Tsirkin, 2021/04/01
- [PULL 5/9] virtio-pci: remove explicit initialization of val,
Michael S. Tsirkin <=
- [PULL 3/9] vhost-user-blk: add immediate cleanup on shutdown, Michael S. Tsirkin, 2021/04/01
- [PULL 6/9] acpi/piix4: reinitialize acpi PM device on reset, Michael S. Tsirkin, 2021/04/01
- [PULL 7/9] vt82c686.c: don't raise SCI when PCI_INTERRUPT_PIN isn't setup, Michael S. Tsirkin, 2021/04/01
- [PULL 8/9] isa/v582c686: Reinitialize ACPI PM device on reset, Michael S. Tsirkin, 2021/04/01
- [PULL 9/9] pci: sprinkle assert in PCI pin number, Michael S. Tsirkin, 2021/04/01
- Re: [PULL 0/9] pc,virtio,pci: bugfixes, Peter Maydell, 2021/04/04