Re: [PATCH v2 01/21] Hexagon (target/hexagon) TCG generation cleanup

[Richard Henderson]

On 4/2/21 12:42 PM, Taylor Simpson wrote:
> > > @@ -43,12 +42,17 @@ static inline void gen_log_predicated_reg_write(int
...
> > Having looked forward at patch 5, it appears this could be further improved
> > by examining ctx->regs_written.
>
> It's not obvious how.  This is for a predicated instruction (e.g., if (p0) r2 = 
> add(r1, r0)), so the checks need to be made at runtime.  There can be more than 
> one predicated instruction in a packet that writes to the same register as long 
> as only one of the predicates is true at runtime.
>
> Am I missing something?

Whoops, no.  I misread where we were here.


r~