|
From: | Alex Bennée |
Subject: | Re: [PATCH v2 07/11] tests/tcg: relax the next step precision of the gdb sha1 test |
Date: | Tue, 06 Apr 2021 10:43:47 +0100 |
User-agent: | mu4e 1.5.11; emacs 28.0.50 |
Richard Henderson <richard.henderson@linaro.org> writes: > On 4/1/21 3:25 AM, Alex Bennée wrote: >> check_break("SHA1Init") >> - # check step and inspect values >> + # Check step and inspect values. We do a double next after the >> + # breakpoint as depending on the version of gdb we may step the >> + # preamble and not the first actual line of source. >> + gdb.execute("next") >> gdb.execute("next") >> val_ctx = gdb.parse_and_eval("context->state[0]") >> exp_ctx = 0x67452301 > > This double next seems just as fragile. Why don't you just set the > breakpoint where you want, which appears to be sha1.c:138? Ideally I'd want an unambiguous label that gdb would understand lest it got broken by someone tweaking the sha1.c code. I thought a function header would be better but it appears only marginally so. > > > r~ -- Alex Bennée
[Prev in Thread] | Current Thread | [Next in Thread] |