Re: [PATCH] nsis: Install *.elf images

[Laurent Vivier]

Le 06/04/2021 à 11:28, Stefan Weil a écrit :
> Am 06.04.21 um 11:04 schrieb Bin Meng:
> 
>> On Fri, Mar 26, 2021 at 2:22 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>>> As of today, the QEMU Windows installer does not include the
>>> following two RISC-V BIOS images:
>>>
>>> - opensbi-riscv64-generic-fw_dynamic.elf
>>> - opensbi-riscv32-generic-fw_dynamic.elf
>>>
>>> Update the installer script to include them.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>>
>>> ---
>>> Based on:
>>> https://repo.or.cz/qemu/ar7.git/commit/657a6a90b69da971afdc71501c30275ba307ff6c
>>>
>>> The above commit does not land on QEMU master. I am not sure what
>>> the process is, sending it here for comments.
>>>
>>>   qemu.nsi | 2 ++
>>>   1 file changed, 2 insertions(+)
>> Ping?
> 
> 
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
> 
> This is a small uncritical fix which can be merged via QEMU trivial.

If it is merged via QEMU trivial, it will be after the 6.0 release.
If it's needed for 6.0 it's better to go via the maintainer tree (W32,W64) [1]

Thanks,
Laurent

[1] the reason is: even a trivial change can break something, I don't like to 
break QEMU during RC
phase, so going via the maintainer tree helps to have tests more relevant to 
the area that is modified.