qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v12 07/65] target/arm: tcg: split tlb_helper user-only and syse


From: Alex Bennée
Subject: Re: [RFC v12 07/65] target/arm: tcg: split tlb_helper user-only and sysemu-only parts
Date: Thu, 08 Apr 2021 15:20:05 +0100
User-agent: mu4e 1.5.11; emacs 28.0.50

Claudio Fontana <cfontana@suse.de> writes:

> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
<snip>
> +#include "qemu/osdep.h"
> +#include "cpu.h"
> +#include "internals.h"
> +#include "exec/exec-all.h"
> +#include "tcg/tlb_helper.h"
> +
> +bool arm_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
> +                      MMUAccessType access_type, int mmu_idx,
> +                      bool probe, uintptr_t retaddr)
> +{
> +    ARMCPU *cpu = ARM_CPU(cs);
> +    ARMMMUFaultInfo fi = {};
> +
> +    int flags = page_get_flags(useronly_clean_ptr(address));
> +    if (flags & PAGE_VALID) {
> +        fi.type = ARMFault_Permission;
> +    } else {
> +        fi.type = ARMFault_Translation;
> +    }

Minor merge conflict caused by dad90de78e (target/arm: Set
ARMMMUFaultInfo.level in user-only arm_cpu_tlb_fill)

Otherwise:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]