[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 02/26] Hexagon (target/hexagon) cleanup gen_log_predicated_reg
From: |
Taylor Simpson |
Subject: |
[PATCH v4 02/26] Hexagon (target/hexagon) cleanup gen_log_predicated_reg_write_pair |
Date: |
Thu, 8 Apr 2021 20:07:30 -0500 |
Similar to previous cleanup of gen_log_predicated_reg_write
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
---
target/hexagon/genptr.c | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c
index 87f5d92..07d970f 100644
--- a/target/hexagon/genptr.c
+++ b/target/hexagon/genptr.c
@@ -69,36 +69,35 @@ static inline void gen_log_reg_write(int rnum, TCGv val)
static void gen_log_predicated_reg_write_pair(int rnum, TCGv_i64 val, int slot)
{
TCGv val32 = tcg_temp_new();
- TCGv one = tcg_const_tl(1);
TCGv zero = tcg_const_tl(0);
TCGv slot_mask = tcg_temp_new();
tcg_gen_andi_tl(slot_mask, hex_slot_cancelled, 1 << slot);
/* Low word */
tcg_gen_extrl_i64_i32(val32, val);
- tcg_gen_movcond_tl(TCG_COND_EQ, hex_new_value[rnum], slot_mask, zero,
- val32, hex_new_value[rnum]);
-#if HEX_DEBUG
- /* Do this so HELPER(debug_commit_end) will know */
- tcg_gen_movcond_tl(TCG_COND_EQ, hex_reg_written[rnum],
+ tcg_gen_movcond_tl(TCG_COND_EQ, hex_new_value[rnum],
slot_mask, zero,
- one, hex_reg_written[rnum]);
-#endif
-
+ val32, hex_new_value[rnum]);
/* High word */
tcg_gen_extrh_i64_i32(val32, val);
tcg_gen_movcond_tl(TCG_COND_EQ, hex_new_value[rnum + 1],
slot_mask, zero,
val32, hex_new_value[rnum + 1]);
#if HEX_DEBUG
- /* Do this so HELPER(debug_commit_end) will know */
- tcg_gen_movcond_tl(TCG_COND_EQ, hex_reg_written[rnum + 1],
- slot_mask, zero,
- one, hex_reg_written[rnum + 1]);
+ /*
+ * Do this so HELPER(debug_commit_end) will know
+ *
+ * Note that slot_mask indicates the value is not written
+ * (i.e., slot was cancelled), so we create a true/false value before
+ * or'ing with hex_reg_written[rnum].
+ */
+ tcg_gen_setcond_tl(TCG_COND_EQ, slot_mask, slot_mask, zero);
+ tcg_gen_or_tl(hex_reg_written[rnum], hex_reg_written[rnum], slot_mask);
+ tcg_gen_or_tl(hex_reg_written[rnum + 1], hex_reg_written[rnum + 1],
+ slot_mask);
#endif
tcg_temp_free(val32);
- tcg_temp_free(one);
tcg_temp_free(zero);
tcg_temp_free(slot_mask);
}
--
2.7.4
- [PATCH v4 00/26] Hexagon (target/hexagon) update, Taylor Simpson, 2021/04/08
- [PATCH v4 07/26] Hexagon (target/hexagon) change variables from int to bool when appropriate, Taylor Simpson, 2021/04/08
- [PATCH v4 06/26] Hexagon (target/hexagon) decide if pred has been written at TCG gen time, Taylor Simpson, 2021/04/08
- [PATCH v4 09/26] Hexagon (target/hexagon) change type of softfloat_roundingmodes, Taylor Simpson, 2021/04/08
- [PATCH v4 04/26] Hexagon (target/hexagon) use env_archcpu and env_cpu, Taylor Simpson, 2021/04/08
- [PATCH v4 10/26] Hexagon (target/hexagon) use softfloat default NaN and tininess, Taylor Simpson, 2021/04/08
- [PATCH v4 01/26] Hexagon (target/hexagon) TCG generation cleanup, Taylor Simpson, 2021/04/08
- [PATCH v4 02/26] Hexagon (target/hexagon) cleanup gen_log_predicated_reg_write_pair,
Taylor Simpson <=
- [PATCH v4 16/26] Hexagon (target/hexagon) compile all debug code, Taylor Simpson, 2021/04/08
- [PATCH v4 08/26] Hexagon (target/hexagon) remove unused carry_from_add64 function, Taylor Simpson, 2021/04/08
- [PATCH v4 03/26] Hexagon (target/hexagon) remove unnecessary inline directives, Taylor Simpson, 2021/04/08
- [PATCH v4 11/26] Hexagon (target/hexagon) replace float32_mul_pow2 with float32_scalbn, Taylor Simpson, 2021/04/08
- [PATCH v4 13/26] Hexagon (target/hexagon) cleanup ternary operators in semantics, Taylor Simpson, 2021/04/08
- [PATCH v4 12/26] Hexagon (target/hexagon) use softfloat for float-to-int conversions, Taylor Simpson, 2021/04/08
- [PATCH v4 18/26] Hexagon (target/hexagon) add F2_sfinvsqrta, Taylor Simpson, 2021/04/08
- [PATCH v4 14/26] Hexagon (target/hexagon) cleanup reg_field_info definition, Taylor Simpson, 2021/04/08
- [PATCH v4 19/26] Hexagon (target/hexagon) add A5_ACS (vacsh), Taylor Simpson, 2021/04/08
- [PATCH v4 15/26] Hexagon (target/hexagon) move QEMU_GENERATE to only be on during macros.h, Taylor Simpson, 2021/04/08