[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] virtiofsd: Fix side-effect in assert()
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] virtiofsd: Fix side-effect in assert() |
Date: |
Fri, 9 Apr 2021 12:23:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/9/21 12:06 PM, Greg Kurz wrote:
> It is bad practice to put an expression with a side-effect in
> assert() because the side-effect won't happen if the code is
> compiled with -DNDEBUG.
>
> Use an intermediate variable. Consolidate this in an macro to
> have proper line numbers when the assertion is hit.
>
> virtiofsd: ../../tools/virtiofsd/passthrough_ll.c:2797: lo_getxattr:
> Assertion `fchdir_res == 0' failed.
> Aborted
>
> 2796 /* fchdir should not fail here */
> =>2797 FCHDIR_NOFAIL(lo->proc_self_fd);
> 2798 ret = getxattr(procname, name, value, size);
> 2799 FCHDIR_NOFAIL(lo->root.fd);
>
> Fixes: bdfd66788349 ("virtiofsd: Fix xattr operations")
> Cc: misono.tomohiro@jp.fujitsu.com
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> tools/virtiofsd/passthrough_ll.c | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>