Re: [RFC v12 12/65] target/arm: move physical address translation to cpu-mmu

[Alex Bennée]

Claudio Fontana <cfontana@suse.de> writes:

> get_phys_addr is needed for KVM too, and in turn it requires
> the aa64_va_parameter* family of functions.
>
> Create cpu-mmu and cpu-mmu-sysemu to store these and
> other mmu-related functions.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/cpu-mmu.h               |  119 ++
>  target/arm/cpu.h                   |    3 -
>  target/arm/internals.h             |   34 -
>  target/arm/cpu-mmu-sysemu.c        | 2307 ++++++++++++++++++++++++++
>  target/arm/cpu-mmu.c               |  124 ++
>  target/arm/cpu.c                   |    1 +
>  target/arm/tcg/helper.c            | 2442 +---------------------------

I realise I reviewed the previous patch but we moved everything
wholesale into target/arm/tcg only to move stuff right back out again. I
can see there maybe an argument for a "move and pare down" approach but
that should probably be expanded on in the comment for 2/65 (move
helpers to tcg).

Anyway:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée