[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common cod
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code |
|
Date: |
Mon, 12 Apr 2021 18:21:55 +0200 |
Am 12.04.2021 um 18:07 hat Thomas Huth geschrieben:
> The ObjectType enum and ObjectOptions are included from qapi-types-qom.h
> into common code. We should not use target-specific config switches like
> CONFIG_VIRTIO_CRYPTO here, since this is not defined in common code and
> thus the enum will look differently between common and target specific
> code. For this case, it's hopefully enough to check for CONFIG_VHOST_CRYPTO
> only (which is a host specific config switch, i.e. it's the same on all
> targets).
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>