qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-6.1] exec: Remove accel/tcg/ from include paths


From: Richard Henderson
Subject: Re: [PATCH-for-6.1] exec: Remove accel/tcg/ from include paths
Date: Tue, 13 Apr 2021 07:20:32 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/13/21 1:10 AM, Philippe Mathieu-Daudé wrote:
When TCG is enabled, the accel/tcg/ include path is added to the
project global include search list. This accel/tcg/ directory
contains a header named "internal.h" which, while intented to
be internal to accel/tcg/, is accessible by all files compiled
when TCG is enabled. This might lead to problem with other
directories using the same "internal.h" header name:

   $ git ls-files | fgrep /internal.h
   accel/tcg/internal.h
   include/hw/ide/internal.h
   target/hexagon/internal.h
   target/mips/internal.h
   target/ppc/internal.h
   target/s390x/internal.h

As we don't need to expose accel/tcg/ internals to the rest of
the code base, simplify by removing it from the include search
list, and include the accel/tcg/ public headers relative to the
project root search path (which is already in the generic include
search path).

Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---

Queued on tcg-next, thanks.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]