[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] target/ppc: code motion from translate_init.c.inc to gdbs
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2] target/ppc: code motion from translate_init.c.inc to gdbstub.c |
|
Date: |
Tue, 13 Apr 2021 08:53:15 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 4/13/21 7:54 AM, Bruno Larsen (billionai) wrote:
+/* gdbstub.c */
+void ppc_gdb_init(CPUState *cs, PowerPCCPUClass *ppc);
+gchar *ppc_gdb_arch_name(CPUState *cs);
These should probably go into internal.h and not cpu.h.
These do not need to be exposed outside of target/ppc/.
+#include "exec/helper-proto.h"
Not ideal, but ok temporarily.
+ gdb_get_reg32(buf, helper_mfvscr(env));
...
+ helper_mtvscr(env, ldl_p(mem_buf));
These should be modeled on e.g. store_fpscr, where there's a non-"helper"
function to be called, which is then called by the "helper" function.
Obviously, splitting that out should be a separate patch.
r~