[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 2/5] tests/docker/dockerfiles/ubuntu2004: Add missing sym
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC PATCH 2/5] tests/docker/dockerfiles/ubuntu2004: Add missing symlink for cc |
Date: |
Wed, 14 Apr 2021 12:16:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/14/21 10:19 AM, Thomas Huth wrote:
> For some reasons, the "cc" symlink is missing in Ubuntu 20.04.
> Add it manually.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/docker/dockerfiles/ubuntu2004.docker | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/docker/dockerfiles/ubuntu2004.docker
> b/tests/docker/dockerfiles/ubuntu2004.docker
> index 9750016e51..e1b309e313 100644
> --- a/tests/docker/dockerfiles/ubuntu2004.docker
> +++ b/tests/docker/dockerfiles/ubuntu2004.docker
> @@ -74,3 +74,6 @@ ENV FEATURES clang tsan pyyaml sdl2
> # Apply patch https://reviews.llvm.org/D75820
> # This is required for TSan in clang-10 to compile with QEMU.
> RUN sed -i 's/^const/static const/g'
> /usr/lib/llvm-10/lib/clang/10.0.0/include/sanitizer/tsan_interface.h
> +
> +# The symlink for cc is missing on Ubuntu
Maybe precise the version: "on Ubuntu 20.04" so we can remove
when upgrading to the next release?
> +RUN cd /usr/lib/ccache && ln -s ../../bin/ccache cc
No need to change current directory:
RUN ln -s ../../bin/ccache /usr/lib/ccache/cc
Or use absolute (but if other use relative, better keep relative,
I haven't check):
RUN ln -s /usr/bin/ccache /usr/lib/ccache/cc
- [RFC PATCH 0/5] Use ccache in the gitlab-CI, Thomas Huth, 2021/04/14
- [RFC PATCH 1/5] tests/docker/dockerfiles: Add ccache to containers where it was missing, Thomas Huth, 2021/04/14
- [RFC PATCH 2/5] tests/docker/dockerfiles/ubuntu2004: Add missing symlink for cc, Thomas Huth, 2021/04/14
- Re: [RFC PATCH 2/5] tests/docker/dockerfiles/ubuntu2004: Add missing symlink for cc,
Philippe Mathieu-Daudé <=
- [RFC PATCH 3/5] gitlab-ci.d/crossbuilds: Limit the amount of targets in the cross-win64 build, Thomas Huth, 2021/04/14
- [RFC PATCH 4/5] gitlab-ci.yml: Compile with ccache enabled, Thomas Huth, 2021/04/14
- [RFC PATCH 5/5] gitlab-ci.d/crossbuilds.yml: Enable compilation with ccache, Thomas Huth, 2021/04/14
- Re: [RFC PATCH 0/5] Use ccache in the gitlab-CI, Stefan Hajnoczi, 2021/04/14