Re: [PATCH] plugins/syscall: Added a table-like summary output

[Mahmoud Mandour]

On Fri, Apr 16, 2021 at 8:54 AM Mahmoud Mandour <ma.mandourr@gmail.com> wrote:

On Thu, Apr 15, 2021 at 5:20 PM Mahmoud Mandour <ma.mandourr@gmail.com> wrote:

Hello. I just realized that this hunk: 

static void vcpu_syscall_ret(qemu_plugin_id_t id, unsigned int vcpu_idx,
                              int64_t num, int64_t ret)
+{
+        // ......
+        if (!syscall_entry) {
+            qemu_plugin_outs(g_strdup_printf("%" PRIi64 "\n", num));
+        }

Is completely superfluous. I think I had it for debugging purposes.

Should I resend without it or can you omit it from the patch?

 

Nevermind, I sent a v2 patch.

Yours,

Mahmoud